Uh oh!
There was an error while loading. Please reload this page.
Partial stabilization of "nonzero_checked_ops". - #97547
Conversation
rust-highfive
commented
May 30, 2022
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
rust-highfive
commented
May 30, 2022
r? @m-ou-se (rust-highfive has picked a reviewer for you, use r? to override) |
iago-lito
commented
May 30, 2022
r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs |
This comment has been minimized.
This comment has been minimized.
9da1c5e to
868eab8Compare
This comment has been minimized.
This comment has been minimized.
868eab8 to
4fcd8a0Compare
This comment has been minimized.
This comment has been minimized.
c321517 to
6b0f59cCompare
This comment has been minimized.
This comment has been minimized.
6b0f59c to
04baca9Compare
This comment has been minimized.
This comment has been minimized.
d3c66d3 to
dd33983Compareyaahc
commented
Jun 8, 2022
@rfcbot merge |
Team member @yaahc has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
yaahc
commented
Jun 8, 2022
I think it's fine to collapse them though I'd definitely recommend having separate PRs that way issues on one part of the PR can't block acceptance of the rest of the PR.
I don't think so, though this is another case where if it's something you need I'd recommend handling that as a separate PR. https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html#when-theres-const-involved |
Uh oh!
There was an error while loading. Please reload this page.
dd33983 to
5823d7bComparerfcbot
commented
Jun 12, 2022
🔔 This is now entering its final comment period, as per the review above. 🔔 |
rfcbot
commented
Jun 22, 2022
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. This will be merged soon. |
…_ops_constness, r=scottmcm Stabilize NonZero* checked operations constness. Partial stabilization for rust-lang#97547 (continued).
…_ops_constness, r=scottmcm Stabilize NonZero* checked operations constness. Partial stabilization for rust-lang#97547 (continued).
…_ops_constness, r=scottmcm Stabilize NonZero* checked operations constness. Partial stabilization for rust-lang#97547 (continued).
…_ops_constness, r=scottmcm Stabilize NonZero* checked operations constness. Partial stabilization for rust-lang#97547 (continued).
…_ops_constness, r=scottmcm Stabilize NonZero* checked operations constness. Partial stabilization for rust-lang#97547 (continued).
Stabilizing checked arithmetics on
NonZerotypes under#.Not closing #84186 as only checked methods are stabilized here.
As per #84186 (comment), the two remaining unchecked methods
unchecked_addandunchecked_mulwill remain feature-gated under#![feature(nonzero_ops)]until #85122 is stabilized.Unresolved questions:
impl Neg for NonZeroI*as part of this PR. Is this the appropriate time to do so?rustc_const_stable. Is this okay?rustc_const_unstableattributes and marked constness of the stabilized methods as feature-gated byconst_nonzero_checked_ops, and referring to Partial stabilization of "nonzero_checked_ops". #97547.. It's the best I could come up with, but it does feel weird, is it?@rustbot modify labels: +T-libs-api