Uh oh!
There was an error while loading. Please reload this page.
Rollup of 6 pull requests - #97548
Merged
Merged
Conversation
Co-authored-by: Ross MacArthur <ross@macarthur.io>
Remove dead code Missing } ./x.py fmt Remove duplicate check Recursively remove all usage of help_on_error
The oldest occurence is from 9e224c2, which is from the pre-1.0 days. In the years since then, std::sys still hasn't been exported, and the last attempt was met with strong criticism: rust-lang#97151 Thus, removing the "yet" part makes a lot of sense.
…an-DPC Use Box::new() instead of box syntax in library tests The tests inside `library/*` have no reason to use `box` syntax as they have 0 performance relevance. Therefore, we can safely remove them (instead of having to use alternatives like the one in rust-lang#97293).
Remove "sys isn't exported yet" phrase The oldest occurence is from 9e224c2, which is from the pre-1.0 days. In the years since then, std::sys still hasn't been exported, and the last attempt was met with strong criticism: rust-lang#97151 Thus, removing the "yet" part makes a lot of sense.
Ensure source file present when calculating max line number Resubmission of rust-lang#89268, fixesrust-lang#71363 The behavior difference of `simulate-remapped-rust-src-base` is not something we should take into account here, so limiting targets to run the test makes sense, I think. r? `@davidtwco,` and `@estebank,` you might be interested in this change
Re-add help_on_error for download-ci-llvm Closesrust-lang#97503 - Re-added `help_on_error` for `download_component()` and the downstream functions - Removed dead code in `bootstrap.py` Thanks `@jyn514` for the helpful tips! (first contribution here, please let me know if I missed anything out!)
…ch, r=davidtwco Note pattern mismatch coming from `for` loop desugaring Fixesrust-lang#97163
Reword safety comments in core/hash/sip.rs In https://rust-lang.zulipchat.com/#narrow/stream/136281-t-lang.2Fwg-unsafe-code-guidelines/topic/Is.20there.20any.20way.20to.20soundly.20do.20a.20masked.20out-of-bounds.20read.3F/near/284329248 it came up that this is using an atypical (and somewhat vague) phrasing of the safety requirement, so this slightly rewords it.
Dylan-DPC
commented
May 30, 2022
MemberAuthor
@bors r+ rollup=never p=5 |
bors
commented
May 30, 2022
Collaborator
📌 Commit a352ad5 has been approved by |
bors
commented
May 30, 2022
Collaborator
bors
commented
May 30, 2022
Collaborator
☀️ Test successful - checks-actions |
This was referenced May 30, 2022
rust-timer
commented
May 30, 2022
Collaborator
Finished benchmarking commit (e810f75): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
forloop desugaring #97531 (Note pattern mismatch coming fromforloop desugaring)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup