Skip to content

add cast kind of from_exposed_addr (int-to-ptr casts) - #97653

Merged
bors merged 2 commits into
rust-lang:masterfrom
RalfJung:int-to-ptr
Jun 3, 2022
Merged

add cast kind of from_exposed_addr (int-to-ptr casts)#97653
bors merged 2 commits into
rust-lang:masterfrom
RalfJung:int-to-ptr

Conversation

@RalfJung

@RalfJungRalfJung commented Jun 2, 2022

Copy link
Copy Markdown
Member

This is basically the dual to #97582, for int2ptr casts.

Cc @tmiasko#97649

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 2, 2022
@rust-highfive

rust-highfive commented Jun 2, 2022

Copy link
Copy Markdown
Contributor

Some changes occured to rustc_codegen_cranelift

cc @bjorn3

Some changes occurred in src/tools/clippy.

cc @rust-lang/clippy

Some changes occured to the CTFE / Miri engine

cc @rust-lang/miri

@rust-highfive

rust-highfive commented Jun 2, 2022

Copy link
Copy Markdown
Contributor

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 2, 2022
RalfJung
RalfJung commented Jun 2, 2022
View reviewed changes
Comment threadcompiler/rustc_borrowck/src/type_check/mod.rs Outdated

@RalfJungRalfJungJun 2, 2022

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oli-obk this looks like logic that would also be nice to have in MIR validation, but without duplicating everything...

@oli-obkoli-obkJun 2, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, I was actually wondering whether we shouldn't move (large) parts of mir typeck to mir validation

@oli-obkoli-obkJun 2, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically anything that doesn't produce obligations I guess

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
RalfJung
RalfJung commented Jun 2, 2022
View reviewed changes
Comment threadcompiler/rustc_codegen_ssa/src/mir/rvalue.rs Outdated
@rust-log-analyzer

This comment has been minimized.

Sign in to view
oli-obk
oli-obk reviewed Jun 2, 2022
View reviewed changes
Comment threadcompiler/rustc_const_eval/src/transform/promote_consts.rs Outdated
@RalfJung@oli-obk
comment
d5a590f
Co-authored-by: Oli Scherer <github35764891676564198441@oli-obk.de>
@oli-obk

oli-obk commented Jun 2, 2022

Copy link
Copy Markdown
Contributor

r? @oli-obk
@bors r+

@bors

bors commented Jun 2, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit d5a590f has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2022
@oli-obkoli-obk added the A-mir-opt Area: MIR optimizations label Jun 2, 2022
@Dylan-DPCDylan-DPC mentioned this pull request Jun 3, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 3, 2022
@bors
Auto merge ofrust-lang#97679- Dylan-DPC:rollup-nswmgmx, r=Dylan-DPC
72f7e31
Rollup of 5 pull requests
Successful merges:
- rust-lang#97366 (Stabilize `{slice,array}::from_ref`)
- rust-lang#97653 (add cast kind of from_exposed_addr (int-to-ptr casts))
- rust-lang#97663 (take back half-baked noaliasing check in Assignment)
- rust-lang#97664 (On E0204 suggest missing type param bounds)
- rust-lang#97668 (rustdoc: clean up primitive.slice.html links)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit f116dd7 into rust-lang:masterJun 3, 2022
@rustbotrustbot added this to the 1.63.0 milestone Jun 3, 2022
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jun 4, 2022
@Dylan-DPC
Rollup merge ofrust-lang#97653- RalfJung:int-to-ptr, r=oli-obk
baacbfd
add cast kind of from_exposed_addr (int-to-ptr casts)
This is basically the dual to rust-lang#97582, for int2ptr casts.
Cc `@tmiasko` rust-lang#97649
@RalfJung
RalfJung deleted the int-to-ptr branch June 5, 2022 15:08
@tedinskitedinski mentioned this pull request Jun 10, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oli-obkoli-obkoli-obk left review comments

Assignees

@oli-obkoli-obk

Labels

A-mir-optArea: MIR optimizationsS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

7 participants

@RalfJung@rust-highfive@rust-log-analyzer@oli-obk@bors@wesleywiser@rustbot