Skip to content

Update LLVM submodule - #97690

Merged
bors merged 1 commit into
rust-lang:masterfrom
nikic:update-llvm-4
Jun 4, 2022
Merged

Update LLVM submodule#97690
bors merged 1 commit into
rust-lang:masterfrom
nikic:update-llvm-4

Conversation

@nikic

@nikicnikic commented Jun 3, 2022

Copy link
Copy Markdown
Contributor

Merge upstream release/14.x branch.

Fixes#97428.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @cuviper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive

Copy link
Copy Markdown
Contributor

⚠️Warning⚠️

  • These commits modify submodules.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 3, 2022
@cuviper

Copy link
Copy Markdown
Member

@bors r+ rollup=iffy

@bors

bors commented Jun 3, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 657cbdf has been approved by cuviper

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2022
@bors

bors commented Jun 4, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 657cbdf with merge 4a52e0f...

@bors

bors commented Jun 4, 2022

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 4a52e0f to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jun 4, 2022
@bors
bors merged commit 4a52e0f into rust-lang:masterJun 4, 2022
@rustbotrustbot added this to the 1.63.0 milestone Jun 4, 2022
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (4a52e0f): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regression found
mean1maxcount2
Regressions 😿
(primary)
N/AN/A0
Regressions 😿
(secondary)
2.5%2.5%1
Improvements 🎉
(primary)
N/AN/A0
Improvements 🎉
(secondary)
N/AN/A0
All 😿🎉 (primary)N/AN/A0

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: 😿 relevant regression found
mean1maxcount2
Regressions 😿
(primary)
N/AN/A0
Regressions 😿
(secondary)
2.5%2.5%1
Improvements 🎉
(primary)
-2.0%-2.0%1
Improvements 🎉
(secondary)
N/AN/A0
All 😿🎉 (primary)-2.0%-2.0%1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change2

  2. number of relevant changes2

@nikicnikic added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 5, 2022
@nikic

nikic commented Jun 7, 2022

Copy link
Copy Markdown
ContributorAuthor

Backport nomination is to fix P-critical miscompile reported in #97428. I think it should be safe to backport the entire LLVM submodule update (as this is just moving along to a newer 14.0.x), and we don't need to pick out just the relevant commit.

@apirainoapiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 8, 2022
@apiraino

Copy link
Copy Markdown
Contributor

Beta backport discussed as per compiler team on Zulip and postponed to next week to better evaluate the entity of the LLVM patch being backported

@apiraino

Copy link
Copy Markdown
Contributor

Beta backport revisited and approved as per compiler team on Zulip

@rustbot label +beta-accepted

@rustbotrustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jun 16, 2022
ehuss pushed a commit to ehuss/rust that referenced this pull request Jun 24, 2022
Update LLVM submodule
Merge upstream release/14.x branch.
Fixesrust-lang#97428.
@ehussehuss mentioned this pull request Jun 24, 2022
@ehussehuss modified the milestones: 1.63.0, 1.62.0Jun 24, 2022
@ehussehuss removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 24, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 24, 2022
[beta] Beta backports
* Remove the unused-#[doc(hidden)] logic from the unused_attributes lint rust-lang#98336
* debuginfo: Fix NatVis for Rc and Arc with unsized pointees. rust-lang#98137
* Revert "remove num_cpus dependency" in rustc and update cargo rust-lang#97911
* Update LLVM submodule rust-lang#97690
* Revert rust-lang#96682. rust-lang#97636
* don't do Sized and other return type checks on RPIT's real type rust-lang#97431
* Temporarily disable submodule archive downloads. rust-lang#98423
@workingjubileeworkingjubilee added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label May 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.beta-acceptedAccepted for backporting to the compiler in the beta channel.merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Infinite recursion optimized away with opt-level=z

9 participants

@nikic@rust-highfive@cuviper@bors@rust-timer@apiraino@ehuss@workingjubilee@rustbot