Uh oh!
There was an error while loading. Please reload this page.
Add proper tracing spans to rustc_trait_selection::traits::error_reporting - #97805
Conversation
rust-highfive
commented
Jun 6, 2022
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
oli-obk
commented
Jun 13, 2022
yea, we're just slowly migrating over to tracing
yea... not sure either. If the function calls other functions, it can be useful, but sometimes that means you have a function whose only log is to nest other calls inside it... 🤷 we'll figure out best practices as we use all of this. |
oli-obk
commented
Jun 21, 2022
@bors r+ rollup |
bors
commented
Jun 21, 2022
📌 Commit 976336d has been approved by |
Rollup of 11 pull requests Successful merges: - rust-lang#94033 (Improve docs for `is_running` to explain use case) - rust-lang#97269 (adjust transmute const stabilization version) - rust-lang#97805 (Add proper tracing spans to rustc_trait_selection::traits::error_reporting) - rust-lang#98022 (Fix erroneous span for borrowck error) - rust-lang#98124 (Improve loading of crates.js and sidebar-items.js) - rust-lang#98278 (Some token stream cleanups) - rust-lang#98306 (`try_fold_unevaluated` for infallible folders) - rust-lang#98313 (Remove lies in comments.) - rust-lang#98323 (:arrow_up: rust-analyzer) - rust-lang#98329 (Avoid an ICE and instead let the compiler report a useful error) - rust-lang#98330 (update ioslice docs to use shared slices) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
While I was trying to figure out #97704 I did some of this to make the logs more legible, so I figured I'd do the whole module and open a PR with it. afaict this is an ongoing process in the compiler from the log->tracing transition? but lmk if there was a reason for the more verbose forms of logging as they are.
Also, for some of the functions with only one log in them, I put the function name as a message for that log instead of
#[instrument]-ing the whole function with a span? but maybe the latter would actually be preferable, I'm not actually sure.