Uh oh!
There was an error while loading. Please reload this page.
Use repr(C) when depending on struct layout in ptr tests - #97851
Merged
Conversation
rust-highfive
commented
Jun 7, 2022
Contributor
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
rust-highfive
commented
Jun 7, 2022
Contributor
r? @thomcc (rust-highfive has picked a reviewer for you, use r? to override) |
thomcc
commented
Jun 8, 2022
Member
Nice catch. @bors r+ |
bors
commented
Jun 8, 2022
Collaborator
📌 Commit 5dd5244 has been approved by |
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Jun 8, 2022
Use repr(C) when depending on struct layout in ptr tests The test depends on the layout of this struct `Pair`, so it should use `repr(C)` instead of the default `repr(Rust)`.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 8, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#97595 (Remove unwrap from get_vtable) - rust-lang#97597 (Preserve unused pointer to address casts) - rust-lang#97819 (Recover `import` instead of `use` in item) - rust-lang#97823 (Recover missing comma after match arm) - rust-lang#97851 (Use repr(C) when depending on struct layout in ptr tests) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test depends on the layout of this struct
Pair, so it should userepr(C)instead of the defaultrepr(Rust).