Skip to content

BTree: tweak internal comments - #97869

Merged
bors merged 1 commit into
rust-lang:masterfrom
ssomers:btree_comments
Jun 14, 2022
Merged

BTree: tweak internal comments#97869
bors merged 1 commit into
rust-lang:masterfrom
ssomers:btree_comments

Conversation

@ssomers

@ssomersssomers commented Jun 8, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Jun 8, 2022

Copy link
Copy Markdown
Contributor

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbotrustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 8, 2022
@rust-highfive

rust-highfive commented Jun 8, 2022

Copy link
Copy Markdown
Contributor

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 8, 2022
@joshtriplett

joshtriplett commented Jun 12, 2022

Copy link
Copy Markdown
Member

r? rust-lang/libs

@Dylan-DPC

Dylan-DPC commented Jun 14, 2022

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Jun 14, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 6f92f5a has been approved by Dylan-DPC

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 14, 2022
@Dylan-DPCDylan-DPC mentioned this pull request Jun 14, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 14, 2022
@Dylan-DPC
Rollup merge ofrust-lang#97869- ssomers:btree_comments, r=Dylan-DPC
f892110
BTree: tweak internal comments
@Dylan-DPCDylan-DPC mentioned this pull request Jun 14, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 14, 2022
@bors
Auto merge ofrust-lang#98091- Dylan-DPC:rollup-ueb6b5x, r=Dylan-DPC
edab34a
Rollup of 5 pull requests
Successful merges:
- rust-lang#97869 (BTree: tweak internal comments)
- rust-lang#97935 (Rename the `ConstS::val` field as `kind`.)
- rust-lang#97948 (lint: add diagnostic translation migration lints)
- rust-lang#98042 (Fix compat_fn option method on miri)
- rust-lang#98069 (rustdoc: remove link on slice brackets)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 4b1d510 into rust-lang:masterJun 14, 2022
@rustbotrustbot added this to the 1.63.0 milestone Jun 14, 2022
@ssomers
ssomers deleted the btree_comments branch June 16, 2022 12:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@thomccthomcc

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

7 participants

@ssomers@rust-highfive@joshtriplett@Dylan-DPC@bors@thomcc@rustbot