Skip to content

rewrite combine doc comment - #97874

Merged
bors merged 1 commit into
rust-lang:masterfrom
lcnr:combine-comment
Jun 9, 2022
Merged

rewrite combine doc comment#97874
bors merged 1 commit into
rust-lang:masterfrom
lcnr:combine-comment

Conversation

@lcnr

@lcnrlcnr commented Jun 8, 2022

Copy link
Copy Markdown
Contributor

it was from 2014 and somewhat outdated

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 8, 2022
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 8, 2022

@davidtwcodavidtwco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r=me if you fix the nit or not.

Comment threadcompiler/rustc_infer/src/infer/combine.rs Outdated
@davidtwcodavidtwco added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2022
@lcnr
lcnrforce-pushed the combine-comment branch from 322842e to 36a4490CompareJune 9, 2022 08:45
@lcnr

lcnr commented Jun 9, 2022

Copy link
Copy Markdown
ContributorAuthor

@bors r=davidtwco rollup

@bors

bors commented Jun 9, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 36a4490 has been approved by davidtwco

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 9, 2022
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jun 9, 2022
rewrite combine doc comment
it was from 2014 and somewhat outdated
@JohnTitorJohnTitor mentioned this pull request Jun 9, 2022
@JohnTitorJohnTitor mentioned this pull request Jun 9, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 9, 2022
Rollup of 5 pull requests
Successful merges:
- rust-lang#95632 (impl Read and Write for VecDeque<u8>)
- rust-lang#95860 (Stabilize `$$` in Rust 1.63.0)
- rust-lang#97838 (hexagon: adapt test for upstream output changes)
- rust-lang#97843 (Relax mipsel-sony-psp's linker script)
- rust-lang#97874 (rewrite combine doc comment)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 141b0a4 into rust-lang:masterJun 9, 2022
@rustbotrustbot added this to the 1.63.0 milestone Jun 9, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@lcnr@rust-highfive@bors@davidtwco@rustbot