Skip to content

remove unneeded code - #97879

Merged
bors merged 1 commit into
rust-lang:masterfrom
hermit-os:condvar
Jun 8, 2022
Merged

remove unneeded code#97879
bors merged 1 commit into
rust-lang:masterfrom
hermit-os:condvar

Conversation

@stlankes

@stlankesstlankes commented Jun 8, 2022

Copy link
Copy Markdown
Contributor

The init function isn't longer part of Condvar. Consequently, we removed the implementation for the target os hermit.

@rust-highfive

rust-highfive commented Jun 8, 2022

Copy link
Copy Markdown
Contributor

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbotrustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 8, 2022
@rust-highfive

rust-highfive commented Jun 8, 2022

Copy link
Copy Markdown
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 8, 2022
@Dylan-DPC

Dylan-DPC commented Jun 8, 2022

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Jun 8, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 85b5f74 has been approved by Dylan-DPC

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2022
@matthiaskrgrmatthiaskrgr mentioned this pull request Jun 8, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 8, 2022
@bors
Auto merge ofrust-lang#97887- matthiaskrgr:rollup-ym5k7kb, r=matthi…
263d868
…askrgr
Rollup of 5 pull requests
Successful merges:
- rust-lang#97507 (Move rustfmt downloads from bootstrap.py to rustbuild)
- rust-lang#97813 (Sync rustc_codegen_gcc)
- rust-lang#97878 (Add regression test for anonymous lifetimes)
- rust-lang#97879 (remove unneeded code)
- rust-lang#97880 (Fix typo: fo->for)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit ef56a1e into rust-lang:masterJun 8, 2022
@rustbotrustbot added this to the 1.63.0 milestone Jun 8, 2022
@mkroeningmkroening mentioned this pull request Jun 26, 2022
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 28, 2022
@Dylan-DPC
Rollup merge ofrust-lang#98555- mkroening:hermit-lock-init, r=m-ou-se
6de107a
Hermit: Fix initializing lazy locks
Closeshermit-os/hermit-rs#322.
The initialization function of hermit's `Condvar` is not called since rust-lang#97647 and was erroneously removed in rust-lang#97879.
r? `@m-ou-se`
CC: `@stlankes`
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 28, 2022
@Dylan-DPC
Rollup merge ofrust-lang#98555- mkroening:hermit-lock-init, r=m-ou-se
f181ae9
Hermit: Fix initializing lazy locks
Closeshermit-os/hermit-rs#322.
The initialization function of hermit's `Condvar` is not called since rust-lang#97647 and was erroneously removed in rust-lang#97879.
r? ``@m-ou-se``
CC: ``@stlankes``
workingjubilee pushed a commit to pgcentralfoundation/postgrestd that referenced this pull request Sep 15, 2022
@Dylan-DPC
Rollup merge of #98555 - mkroening:hermit-lock-init, r=m-ou-se
58f1f02
Hermit: Fix initializing lazy locks
Closeshermit-os/hermit-rs#322.
The initialization function of hermit's `Condvar` is not called since rust-lang/rust#97647 and was erroneously removed in rust-lang/rust#97879.
r? ``@m-ou-se``
CC: ``@stlankes``
@mkroening
mkroening deleted the condvar branch December 11, 2022 19:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

6 participants

@stlankes@rust-highfive@Dylan-DPC@bors@Mark-Simulacrum@rustbot