diagnostics: remove trailing spaces by klensy · Pull Request #97892 · rust-lang/rust

klensy · 2022-06-08T18:28:45Z

Remove few occurrences of trailing spaces and drive by fix of needless alloc of const string.

rust-highfive · 2022-06-08T18:28:49Z

(rust-highfive has picked a reviewer for you, use r? to override)

bors · 2022-06-12T04:07:18Z

☔ The latest upstream changes (presumably #97778) made this pull request unmergeable. Please resolve the merge conflicts.

oli-obk · 2022-06-13T08:44:40Z

@bors r+

bors · 2022-06-13T08:44:42Z

📌 Commit fbb6636 has been approved by oli-obk

diagnostics: remove trailing spaces Remove few occurrences of trailing spaces and drive by fix of needless alloc of const string.

Dylan-DPC · 2022-06-14T13:42:38Z

@bors r=iffy

bors · 2022-06-14T13:42:40Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: Integrate measureme's hardware performance counter support. #78781

bors · 2022-06-14T13:42:41Z

📌 Commit fbb6636 has been approved by iffy

Dylan-DPC · 2022-06-14T13:42:47Z

lol

@bors rollup=iffy

Dylan-DPC · 2022-06-14T13:43:08Z

bors r=oli-obk

Dylan-DPC · 2022-06-14T13:43:27Z

@bors r=oli-obk

(sorry for the noise :P)

bors · 2022-06-14T13:43:28Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: Integrate measureme's hardware performance counter support. #78781

bors · 2022-06-14T13:43:29Z

📌 Commit fbb6636 has been approved by oli-obk

bors · 2022-06-14T20:29:18Z

⌛ Testing commit fbb6636 with merge 058e0ebdb3b3ac083cd77fa7f32893862fdc9656...

bors · 2022-06-14T20:58:56Z

💔 Test failed - checks-actions

klensy · 2022-06-15T17:37:12Z

blessed clippy tests, hope no more left.

Dylan-DPC · 2022-06-16T05:16:25Z

@bors r=oli-obk

klensy · 2022-06-16T12:52:48Z

Rebased. Tests rot quite fast, sadly.

Dylan-DPC · 2022-06-16T13:11:27Z

@bors r=oli-obk

bors · 2022-06-16T13:11:28Z

📌 Commit 6fc412f has been approved by oli-obk

bors · 2022-06-16T13:54:26Z

⌛ Testing commit 6fc412f with merge ebdd693854f9118a54e4ee9fdad778cbc7d8e099...

klensy · 2022-06-16T16:41:36Z

job auto (i686-gnu-nopt, ubuntu-20.04-xl): looks like it hangs.

bors · 2022-06-16T18:09:26Z

💥 Test timed out

rust-log-analyzer · 2022-06-16T18:22:57Z

A job failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

Dylan-DPC · 2022-06-17T05:28:29Z

@bors retry

bors · 2022-06-17T17:30:20Z

⌛ Testing commit 6fc412f with merge 0cb9899...

bors · 2022-06-17T20:10:57Z

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 0cb9899 to master...

rust-timer · 2022-06-17T21:30:15Z

Finished benchmarking commit (0cb9899): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

Primary benchmarks: no relevant changes found
Secondary benchmarks: 🎉 relevant improvement found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-2.9%	-2.9%	1
All 😿🎉 (primary)	N/A	N/A	0

Cycles

Results

Primary benchmarks: 😿 relevant regression found
Secondary benchmarks: 😿 relevant regression found

	mean¹	max	count²
Regressions 😿 (primary)	2.7%	2.7%	1
Regressions 😿 (secondary)	2.0%	2.0%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	2.7%	2.7%	1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

the arithmetic mean of the percent change↩↩²
number of relevant changes↩↩²

diagnostics: remove trailing spaces Remove few occurrences of trailing spaces and drive by fix of needless alloc of const string.

rust-highfive assigned oli-obk Jun 8, 2022

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 8, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 8, 2022

This comment has been minimized.
Sign in to view

klensy force-pushed the fix-spaces branch 2 times, most recently from 62f2eea to fbb6636Compare June 12, 2022 06:59

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2022

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 13, 2022
Rollup merge ofrust-lang#97892- klensy:fix-spaces, r=oli-obk
17212dd
diagnostics: remove trailing spaces Remove few occurrences of trailing spaces and drive by fix of needless alloc of const string.

Dylan-DPC mentioned this pull request Jun 13, 2022
Rollup of 5 pull requests #98045
Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 14, 2022

klensy force-pushed the fix-spaces branch from fbb6636 to cc76f0bCompare June 15, 2022 11:40

klensy added 4 commits June 16, 2022 14:40

diagnostics: fix trailing space
0ff8ae3

fix one more case of trailing space
989d1a7

drive by fix needless allocation of const string number
68ea8ff

bless rustdoc-ui tests
449ad04

This comment has been minimized.
Sign in to view

bless clippy tests
6fc412f

klensy force-pushed the fix-spaces branch from cc76f0b to 6fc412fCompare June 16, 2022 12:51

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 16, 2022

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 16, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 17, 2022

bors merged commit 0cb9899 into rust-lang:masterJun 17, 2022

rustbot added this to the 1.63.0 milestone Jun 17, 2022

bors mentioned this pull request Jun 17, 2022
Make TAIT behave exactly like RPIT #96727
Merged

flip1995 pushed a commit to flip1995/rust that referenced this pull request Jun 30, 2022
Auto merge ofrust-lang#97892- klensy:fix-spaces, r=oli-obk
09c9301
diagnostics: remove trailing spaces Remove few occurrences of trailing spaces and drive by fix of needless alloc of const string.

Uh oh!

Uh oh!

Conversation

klensy commented Jun 8, 2022

Uh oh!

rust-highfive commented Jun 8, 2022

Uh oh!

This comment has been minimized.

bors commented Jun 12, 2022

Uh oh!

oli-obk commented Jun 13, 2022

Uh oh!

bors commented Jun 13, 2022

Uh oh!

Dylan-DPC commented Jun 14, 2022

Uh oh!

bors commented Jun 14, 2022

Uh oh!

bors commented Jun 14, 2022

Uh oh!

Dylan-DPC commented Jun 14, 2022

Uh oh!

Dylan-DPC commented Jun 14, 2022

Uh oh!

Dylan-DPC commented Jun 14, 2022

Uh oh!

bors commented Jun 14, 2022

Uh oh!

bors commented Jun 14, 2022

Uh oh!

bors commented Jun 14, 2022

Uh oh!

bors commented Jun 14, 2022

Uh oh!

klensy commented Jun 15, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dylan-DPC commented Jun 16, 2022

Uh oh!

This comment has been minimized.

klensy commented Jun 16, 2022

Uh oh!

Dylan-DPC commented Jun 16, 2022

Uh oh!

bors commented Jun 16, 2022

Uh oh!

bors commented Jun 16, 2022

Uh oh!

klensy commented Jun 16, 2022

Uh oh!

bors commented Jun 16, 2022

Uh oh!

rust-log-analyzer commented Jun 16, 2022

Uh oh!

Dylan-DPC commented Jun 17, 2022

Uh oh!

bors commented Jun 17, 2022

Uh oh!

bors commented Jun 17, 2022

Uh oh!

rust-timer commented Jun 17, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

klensy commented Jun 15, 2022•
edited
Loading