Skip to content

Rustdoc: Fix stab disappearing and exclude cfg "doc" and "doctest" - #98108

Merged
bors merged 2 commits into
rust-lang:masterfrom
SpriteOvO:doc_auto_cfg-feature-rmv-fix
Jun 16, 2022
Merged

Rustdoc: Fix stab disappearing and exclude cfg "doc" and "doctest"#98108
bors merged 2 commits into
rust-lang:masterfrom
SpriteOvO:doc_auto_cfg-feature-rmv-fix

Conversation

@SpriteOvO

@SpriteOvOSpriteOvO commented Jun 14, 2022

Copy link
Copy Markdown
Member

@rustbotrustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jun 14, 2022
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 14, 2022
@SpriteOvO
SpriteOvOforce-pushed the doc_auto_cfg-feature-rmv-fix branch 3 times, most recently from e450d7f to 07112a9CompareJune 14, 2022 20:10
GuillaumeGomez
GuillaumeGomez reviewed Jun 15, 2022
View reviewed changes
Comment threadsrc/test/rustdoc/doc-auto-cfg.rs Outdated
@GuillaumeGomez

GuillaumeGomez commented Jun 15, 2022

Copy link
Copy Markdown
Member

Apart from the little nit in the test, looks good to me, thanks!

Want to take a look as well @notriddle ?

@SpriteOvO
SpriteOvOforce-pushed the doc_auto_cfg-feature-rmv-fix branch from 07112a9 to 72a5673CompareJune 15, 2022 10:53
notriddle
notriddle requested changes Jun 15, 2022
View reviewed changes

@notriddlenotriddle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. Just one little nitpick, then we merge!

Comment threadsrc/librustdoc/clean/cfg.rs Outdated
@SpriteOvO
SpriteOvOforce-pushed the doc_auto_cfg-feature-rmv-fix branch from 72a5673 to 713578bCompareJune 15, 2022 17:15
@notriddle

notriddle commented Jun 15, 2022

Copy link
Copy Markdown
Contributor

@bors r=notriddle,GuillaumeGomez

@bors

bors commented Jun 15, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 713578b has been approved by notriddle,GuillaumeGomez

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 15, 2022
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 15, 2022
@GuillaumeGomez
Rollup merge ofrust-lang#98108- SpriteOvO:doc_auto_cfg-feature-rmv-…
bb3d1ad
…fix, r=notriddle,GuillaumeGomez
Rustdoc: Fix stab disappearing and exclude cfg "doc" and "doctest"
Fixesrust-lang#98065 Context: rust-lang#43781 (comment)
r? `@GuillaumeGomez`
@GuillaumeGomezGuillaumeGomez mentioned this pull request Jun 15, 2022
Closed
@bors

bors commented Jun 16, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 713578b with merge 392d272...

@bors

bors commented Jun 16, 2022

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: notriddle,GuillaumeGomez
Pushing 392d272 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jun 16, 2022
@bors
bors merged commit 392d272 into rust-lang:masterJun 16, 2022
@rustbotrustbot added this to the 1.63.0 milestone Jun 16, 2022
@SpriteOvO
SpriteOvO deleted the doc_auto_cfg-feature-rmv-fix branch June 16, 2022 07:54
@rust-timer

rust-timer commented Jun 16, 2022

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (392d272): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: 🎉 relevant improvements found
mean1maxcount2
Regressions 😿
(primary)		2.0%2.0%1
Regressions 😿
(secondary)		N/AN/A0
Improvements 🎉
(primary)		-0.8%-0.8%1
Improvements 🎉
(secondary)		-3.2%-4.3%2
All 😿🎉 (primary)0.6%2.0%2

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: mixed results
mean1maxcount2
Regressions 😿
(primary)		N/AN/A0
Regressions 😿
(secondary)		2.5%2.9%2
Improvements 🎉
(primary)		-3.4%-3.4%1
Improvements 🎉
(secondary)		-2.2%-2.2%1
All 😿🎉 (primary)-3.4%-3.4%1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change↩↩2

  2. number of relevant changes↩↩2

@GuillaumeGomezGuillaumeGomez mentioned this pull request Oct 1, 2022
Closed
@ghostghost mentioned this pull request Oct 11, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomezGuillaumeGomezGuillaumeGomez left review comments
@notriddlenotriddlenotriddle requested changes

Assignees

@GuillaumeGomezGuillaumeGomez

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

Remove cfg(doc) and cfg(doctest) from doc_auto_cfg, fix not() making badge disappear

7 participants

@SpriteOvO@GuillaumeGomez@notriddle@bors@rust-timer@rust-highfive@rustbot