Skip to content

Refactor path segment parameter error - #98119

Merged
bors merged 1 commit into
rust-lang:masterfrom
EdwinRy:path-parenthesized-type-error
Jun 16, 2022
Merged

Refactor path segment parameter error#98119
bors merged 1 commit into
rust-lang:masterfrom
EdwinRy:path-parenthesized-type-error

Conversation

@EdwinRy

Copy link
Copy Markdown
Contributor

This PR attempts to rewrite the error handling for an unexpected parenthesised type parameters to:

  • Use provided data instead of re-parsing the whole span
  • Add a multipart suggestion to reflect on the changes with an underline
  • Remove the unnecessary "if" nesting

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 15, 2022
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 15, 2022
@estebank

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jun 15, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 71a98e1 has been approved by estebank

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 15, 2022
@JohnTitorJohnTitor mentioned this pull request Jun 15, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 15, 2022
Rollup of 7 pull requests
Successful merges:
- rust-lang#97202 (os str capacity documentation)
- rust-lang#97964 (Fix suggestions for `&a: T` parameters)
- rust-lang#98053 (Fix generic impl rustdoc json output)
- rust-lang#98059 (Inline `const_eval_select`)
- rust-lang#98092 (Fix sidebar items expand collapse)
- rust-lang#98119 (Refactor path segment parameter error)
- rust-lang#98135 (Add regression test for rust-lang#93775)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit bfc6c90 into rust-lang:masterJun 16, 2022
@rustbotrustbot added this to the 1.63.0 milestone Jun 16, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@EdwinRy@rust-highfive@estebank@bors@rustbot