Implement `fs::get_path` for FreeBSD. by devnexen · Pull Request #98211 · rust-lang/rust

devnexen · 2022-06-17T19:36:33Z

Using F_KINFO fcntl flag, the kf_structsize field
needs to be set beforehand for that effect.

rust-highfive · 2022-06-17T19:36:36Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

rust-highfive · 2022-06-17T19:36:37Z

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

JohnCSimon · 2022-07-23T23:48:11Z

Ping from triage:
@devnexen - What is the status of this PR? If you're not moving forward with this, please close it.

FYI: when a PR is ready for review, send a message containing
@rustbot ready to switch to S-waiting-on-review so the PR is in the reviewer's backlog.

devnexen · 2022-07-24T05:14:47Z

@rustbot ready

Mark-Simulacrum · 2022-07-24T15:10:32Z

Hm, so looking at how large that struct is, I'm now wondering if we should be placing it on the heap -- it seems like a kilobyte+ is a pretty big thing to stick onto the stack. I think our stacks are typically a few megabytes, and this function can't see any recursion, but the heap allocation is also likely to be pretty cheap when we're making a syscall anyway.

It looks like on other platforms the get_path helpers all use a heap allocation, so adding one here won't be too odd hopefully.

devnexen · 2022-07-24T20:30:49Z

@rustbot ready

Mark-Simulacrum · 2022-07-24T20:36:36Z

@bors r+

bors · 2022-07-24T20:36:38Z

📌 Commit 5803492 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

…imulacrum Implement `fs::get_path` for FreeBSD. Using `F_KINFO` fcntl flag, the kf_structsize field needs to be set beforehand for that effect.

JohnTitor · 2022-07-25T22:13:39Z

Failed in rollup: #99726 (comment)
@bors r-

devnexen · 2022-07-25T22:17:42Z

oh I forgot it was only amd64 arch...

Using `F_KINFO` fcntl flag, the kf_structsize field needs to be set beforehand for that effect.

Mark-Simulacrum · 2022-07-25T23:09:14Z

@bors r+

bors · 2022-07-25T23:09:15Z

📌 Commit e39b44a has been approved by Mark-Simulacrum

It is now in the queue for this repository.

Rollup of 7 pull requests Successful merges: - rust-lang#98211 (Implement `fs::get_path` for FreeBSD.) - rust-lang#99353 (Slightly improve mismatched GAT where clause error) - rust-lang#99593 (Suggest removing the tuple struct field for the unwrapped value) - rust-lang#99615 (Remove some explicit `self.infcx` for `FnCtxt`, which already derefs into `InferCtxt`) - rust-lang#99711 (Remove reachable coverage without counters) - rust-lang#99718 (Avoid `&str`/`Symbol` to `String` conversions) - rust-lang#99720 (Sync rustc_codegen_cranelift) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned Mark-Simulacrum Jun 17, 2022

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 17, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 17, 2022

Mark-Simulacrum reviewed Jun 18, 2022
View reviewed changes

Comment threadlibrary/std/src/sys/unix/fs.rs Outdated

Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2022

devnexen force-pushed the get_path_freebsd branch from 302baa3 to 047a842Compare June 18, 2022 15:44

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 24, 2022

Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2022

devnexen force-pushed the get_path_freebsd branch from 047a842 to 32d80f4Compare July 24, 2022 19:24

This comment was marked as resolved.
Sign in to view

Mark-Simulacrum reviewed Jul 24, 2022
View reviewed changes

Comment threadlibrary/std/src/sys/unix/fs.rs Outdated

Mark-Simulacrum reviewed Jul 24, 2022
View reviewed changes

Comment threadlibrary/std/src/sys/unix/fs.rs Outdated

devnexen force-pushed the get_path_freebsd branch from 32d80f4 to 5803492Compare July 24, 2022 20:06

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 24, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2022

Dylan-DPC mentioned this pull request Jul 25, 2022
Rollup of 7 pull requests #99726
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 25, 2022

Implement fs::get_path for FreeBSD.
e39b44a
Using `F_KINFO` fcntl flag, the kf_structsize field needs to be set beforehand for that effect.

devnexen force-pushed the get_path_freebsd branch from 5803492 to e39b44aCompare July 25, 2022 22:26

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 25, 2022

JohnTitor mentioned this pull request Jul 26, 2022
Rollup of 7 pull requests #99745
Merged

bors merged commit d3acd00 into rust-lang:masterJul 26, 2022

rustbot added this to the 1.64.0 milestone Jul 26, 2022

Uh oh!

Uh oh!

Conversation

devnexen commented Jun 17, 2022

Uh oh!

rust-highfive commented Jun 17, 2022

Uh oh!

rust-highfive commented Jun 17, 2022

Uh oh!

Uh oh!

JohnCSimon commented Jul 23, 2022

Uh oh!

devnexen commented Jul 24, 2022

Uh oh!

Mark-Simulacrum commented Jul 24, 2022

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

devnexen commented Jul 24, 2022

Uh oh!

Mark-Simulacrum commented Jul 24, 2022

Uh oh!

bors commented Jul 24, 2022

Uh oh!

JohnTitor commented Jul 25, 2022

Uh oh!

devnexen commented Jul 25, 2022

Uh oh!

Mark-Simulacrum commented Jul 25, 2022

Uh oh!

bors commented Jul 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants