Skip to content

Perform coherence checking per impl. - #98221

Merged
bors merged 3 commits into
rust-lang:masterfrom
cjgillot:single-coh
Jun 27, 2022
Merged

Perform coherence checking per impl.#98221
bors merged 3 commits into
rust-lang:masterfrom
cjgillot:single-coh

Conversation

@cjgillot

@cjgillotcjgillot commented Jun 18, 2022

Copy link
Copy Markdown
Contributor

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 18, 2022
@cjgillot

cjgillot commented Jun 18, 2022

Copy link
Copy Markdown
ContributorAuthor

@bors try @rust-timer queue

@rust-timer

rust-timer commented Jun 18, 2022

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbotrustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 18, 2022
@bors

bors commented Jun 18, 2022

Copy link
Copy Markdown
Collaborator

⌛ Trying commit aa9f4b6b3a12366b2aedb2cdb0355f2c55ddbf8b with merge d5f00052a2d1e4fac321aaf259b637698d417f23...

@bors

bors commented Jun 18, 2022

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: d5f00052a2d1e4fac321aaf259b637698d417f23 (d5f00052a2d1e4fac321aaf259b637698d417f23)

@rust-timer

rust-timer commented Jun 18, 2022

Copy link
Copy Markdown
Collaborator

Queued d5f00052a2d1e4fac321aaf259b637698d417f23 with parent ff86b27, future comparison URL.

@rust-timer

rust-timer commented Jun 18, 2022

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (d5f00052a2d1e4fac321aaf259b637698d417f23): comparison url.

Instruction count

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regression found
mean1maxcount2
Regressions 😿
(primary)		N/AN/A0
Regressions 😿
(secondary)		1.8%1.8%1
Improvements 🎉
(primary)		N/AN/A0
Improvements 🎉
(secondary)		N/AN/A0
All 😿🎉 (primary)N/AN/A0

Max RSS (memory usage)

Results
  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: 🎉 relevant improvement found
mean1maxcount2
Regressions 😿
(primary)		N/AN/A0
Regressions 😿
(secondary)		N/AN/A0
Improvements 🎉
(primary)		-1.7%-1.8%2
Improvements 🎉
(secondary)		-2.8%-2.8%1
All 😿🎉 (primary)-1.7%-1.8%2

Cycles

Results
  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: 🎉 relevant improvement found
mean1maxcount2
Regressions 😿
(primary)		1.9%1.9%1
Regressions 😿
(secondary)		N/AN/A0
Improvements 🎉
(primary)		N/AN/A0
Improvements 🎉
(secondary)		-2.5%-2.5%1
All 😿🎉 (primary)1.9%1.9%1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. the arithmetic mean of the percent change↩↩2↩3

  2. number of relevant changes↩↩2↩3

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 18, 2022
lcnr
lcnr reviewed Jun 20, 2022
View reviewed changes
Comment threadcompiler/rustc_typeck/src/coherence/orphan.rs Outdated

@lcnrlcnrJun 20, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can return Err(ErrorGuaranteed) here, as i think we also want to silence any future errors if the trait ref is invalid

lcnr
lcnr reviewed Jun 20, 2022
View reviewed changes
Comment threadcompiler/rustc_typeck/src/coherence/orphan.rs Outdated

@lcnrlcnrJun 20, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fnlint_auto_trait_impls<'tcx>(
fnlint_auto_trait_impl<'tcx>(

@cjgillot

cjgillot commented Jun 22, 2022

Copy link
Copy Markdown
ContributorAuthor

r? @lcnr

@lcnr

lcnr commented Jun 23, 2022

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jun 23, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 9388824 has been approved by lcnr

@bors

bors commented Jun 23, 2022

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2022
@bors

bors commented Jun 27, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9388824 with merge 7702ae1...

@bors

bors commented Jun 27, 2022

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 7702ae1 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jun 27, 2022
@bors
bors merged commit 7702ae1 into rust-lang:masterJun 27, 2022
@rustbotrustbot added this to the 1.64.0 milestone Jun 27, 2022
@borsbors mentioned this pull request Jun 27, 2022
Closed
@rust-timer

rust-timer commented Jun 27, 2022

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (7702ae1): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: no relevant changes found
mean1maxcount2
Regressions 😿
(primary)		N/AN/A0
Regressions 😿
(secondary)		N/AN/A0
Improvements 🎉
(primary)		-1.9%-1.9%1
Improvements 🎉
(secondary)		N/AN/A0
All 😿🎉 (primary)-1.9%-1.9%1

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: no relevant changes found
mean1maxcount2
Regressions 😿
(primary)		N/AN/A0
Regressions 😿
(secondary)		N/AN/A0
Improvements 🎉
(primary)		-7.4%-7.4%1
Improvements 🎉
(secondary)		N/AN/A0
All 😿🎉 (primary)-7.4%-7.4%1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change↩↩2

  2. number of relevant changes↩↩2

@cjgillot
cjgillot deleted the single-coh branch June 27, 2022 06:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcnrlcnrlcnr left review comments

Assignees

@lcnrlcnr

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.64.0

Development

Successfully merging this pull request may close these issues.

5 participants

@cjgillot@rust-timer@bors@lcnr@rustbot