Only keep a single query for well-formed checking

[cjgillot]

There are currently 3 queries to perform wf checks on different item-likes. This complexity is not required.

This PR replaces the query by:

• one query per item;
• one query to invoke it for a whole module.

This allows to remove HIR ParItemLikeVisitor.

[cjgillot]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 8c9db2bd13646486dd4aa70df31f0a0456c935bb with merge f63048577aa48b759330fc42ece772164f7b0950...

[bors]

☀️ Try build successful - checks-actions
Build commit: f63048577aa48b759330fc42ece772164f7b0950 (f63048577aa48b759330fc42ece772164f7b0950)

[rust-timer]

Queued f63048577aa48b759330fc42ece772164f7b0950 with parent ff86b27, future comparison URL.

[rust-timer]

Finished benchmarking commit (f63048577aa48b759330fc42ece772164f7b0950): comparison url.

Instruction count

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: 🎉 relevant improvements found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-0.3%	-0.3%	3
All 😿🎉 (primary)	N/A	N/A	0

Max RSS (memory usage)

Results

• Primary benchmarks: 🎉 relevant improvements found
• Secondary benchmarks: 🎉 relevant improvement found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-2.1%	-2.6%	3
Improvements 🎉 (secondary)	-4.9%	-4.9%	1
All 😿🎉 (primary)	-2.1%	-2.6%	3

Cycles

Results

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: 🎉 relevant improvement found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-2.5%	-2.5%	1
All 😿🎉 (primary)	N/A	N/A	0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

1. the arithmetic mean of the percent change↩↩²↩³

2. number of relevant changes↩↩²↩³

[cjgillot]

r? rust-lang/compiler

[michaelwoerister]

Looks good to me, thanks @cjgillot!

@bors r+

[bors]

📌 Commit f446bbc has been approved by michaelwoerister

[bors]

⌛ Testing commit f446bbc with merge 5ffa8f6...

[bors]

☀️ Test successful - checks-actions
Approved by: michaelwoerister
Pushing 5ffa8f6 to master...

[rust-timer]

Finished benchmarking commit (5ffa8f6): comparison url.

Instruction count

• Primary benchmarks: 🎉 relevant improvements found
• Secondary benchmarks: 🎉 relevant improvements found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-0.2%	-0.3%	2
Improvements 🎉 (secondary)	-0.2%	-0.3%	7
All 😿🎉 (primary)	-0.2%	-0.3%	2

Max RSS (memory usage)

Results

• Primary benchmarks: 🎉 relevant improvement found
• Secondary benchmarks: mixed results

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	2.1%	2.1%	1
Improvements 🎉 (primary)	-2.2%	-2.2%	1
Improvements 🎉 (secondary)	-3.3%	-3.3%	1
All 😿🎉 (primary)	-2.2%	-2.2%	1

Cycles

Results

• Primary benchmarks: mixed results
• Secondary benchmarks: 🎉 relevant improvement found

	mean1	max	count2
Regressions 😿 (primary)	4.5%	4.5%	1
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-2.1%	-2.1%	3
Improvements 🎉 (secondary)	-3.0%	-3.0%	1
All 😿🎉 (primary)	-0.4%	4.5%	4

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

1. the arithmetic mean of the percent change↩↩²↩³

2. number of relevant changes↩↩²↩³