Skip to content

Remove accidental uses of &A: Allocator - #98233

Merged
bors merged 2 commits into
rust-lang:masterfrom
RalfJung:ref-alloc
Jun 19, 2022
Merged

Remove accidental uses of &A: Allocator#98233
bors merged 2 commits into
rust-lang:masterfrom
RalfJung:ref-alloc

Conversation

@RalfJung

@RalfJungRalfJung commented Jun 18, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Cc #98232

Fixes#98176 (for real this time)

@rust-highfive

rust-highfive commented Jun 18, 2022

Copy link
Copy Markdown
Contributor

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbotrustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 18, 2022
@rust-highfive

rust-highfive commented Jun 18, 2022

Copy link
Copy Markdown
Contributor

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 18, 2022
@RalfJungRalfJung mentioned this pull request Jun 18, 2022
Closed
@RalfJung

RalfJung commented Jun 18, 2022

Copy link
Copy Markdown
MemberAuthor

r? @thomcc

@rust-highfiverust-highfive assigned thomcc and unassigned kennytmJun 18, 2022
@thomcc

thomcc commented Jun 18, 2022

Copy link
Copy Markdown
Member

LGTM.

@bors r+

@bors

bors commented Jun 18, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit b05d71f has been approved by thomcc

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2022
@Dylan-DPCDylan-DPC mentioned this pull request Jun 19, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 19, 2022
@Dylan-DPC
Rollup merge ofrust-lang#98233- RalfJung:ref-alloc, r=thomcc
17cfc77
Remove accidental uses of `&A: Allocator`
Cc rust-lang#98232Fixesrust-lang#98176 (for real this time)
@Dylan-DPCDylan-DPC mentioned this pull request Jun 19, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 19, 2022
@bors
Auto merge ofrust-lang#98255- Dylan-DPC:rollup-hr129rg, r=Dylan-DPC
68d0b29
Rollup of 5 pull requests
Successful merges:
- rust-lang#98105 (rustdoc: remove tuple link on round braces)
- rust-lang#98136 (Rename `impl_constness` to `constness`)
- rust-lang#98146 (Remove --memory-init-file flag when linking with Emscripten)
- rust-lang#98219 (Skip late bound regions in GATSubstCollector)
- rust-lang#98233 (Remove accidental uses of `&A: Allocator`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 6a2a56d into rust-lang:masterJun 19, 2022
@rustbotrustbot added this to the 1.63.0 milestone Jun 19, 2022
@RalfJung
RalfJung deleted the ref-alloc branch June 21, 2022 23:30
@RalfJungRalfJung mentioned this pull request Jun 21, 2022
Merged
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jun 22, 2022
@JohnTitor
Rollup merge ofrust-lang#98363- RalfJung:btree-test-ref-alloc, r=th…
ae8c200
…omcc
remove use of &Alloc in btree tests
I missed these in rust-lang#98233.
r? `@thomcc`
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jun 22, 2022
@JohnTitor
Rollup merge ofrust-lang#98363- RalfJung:btree-test-ref-alloc, r=th…
db64923
…omcc
remove use of &Alloc in btree tests
I missed these in rust-lang#98233.
r? ``@thomcc``
workingjubilee pushed a commit to pgcentralfoundation/postgrestd that referenced this pull request Sep 15, 2022
@JohnTitor
Rollup merge of #98363 - RalfJung:btree-test-ref-alloc, r=thomcc
a8a9d2d
remove use of &Alloc in btree tests
I missed these in rust-lang/rust#98233.
r? ``@thomcc``
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@thomccthomcc

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

ICE: invalid scalar pair layout

6 participants

@RalfJung@rust-highfive@thomcc@bors@kennytm@rustbot