Skip to content

update Miri - #98397

Merged
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:miri
Jun 24, 2022
Merged

update Miri#98397
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:miri

Conversation

@RalfJung

@RalfJungRalfJung commented Jun 22, 2022

Copy link
Copy Markdown
Member

Fixes#98366
r? @ghost Cc @rust-lang/miri

@RalfJung

RalfJung commented Jun 22, 2022

Copy link
Copy Markdown
MemberAuthor

@bors r+ p=1

@bors

bors commented Jun 22, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 2a7402ac3875c1373c0ac9ffc0ae96d6afd0d836 has been approved by RalfJung

@bors

bors commented Jun 22, 2022

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 22, 2022
@klensy

klensy commented Jun 22, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Should #98386 be closed?

@RalfJung

RalfJung commented Jun 22, 2022

Copy link
Copy Markdown
MemberAuthor

Oh, sorry, I hadn't seen that.
But yeah my PR contains the fix for rust-lang/miri#2238 so I'll close the other one.

@RalfJungRalfJung mentioned this pull request Jun 22, 2022
Closed
@rust-log-analyzer

This comment was marked as resolved.

Sign in to view
@RalfJungRalfJung reopened this Jun 23, 2022
@RalfJung

RalfJung commented Jun 23, 2022

Copy link
Copy Markdown
MemberAuthor

@bors r+

@bors

bors commented Jun 23, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 08789aa has been approved by RalfJung

@bors

bors commented Jun 23, 2022

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@bors

bors commented Jun 23, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 08789aa with merge 3e6f183e018e66d2986faacb0504e33121996a17...

@bors

bors commented Jun 24, 2022

Copy link
Copy Markdown
Collaborator

💥 Test timed out

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 24, 2022
@ehuss

ehuss commented Jun 24, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

@bors retry

dist-x86_64-linux-alt is hung at 5 hours

EDIT: Hung at:

 Updating crates.io index
Error: The operation was canceled.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2022
@rust-log-analyzer

This comment was marked as resolved.

Sign in to view
@RalfJungRalfJung reopened this Jun 24, 2022
@RalfJung

RalfJung commented Jun 24, 2022

Copy link
Copy Markdown
MemberAuthor

@bors r+

@bors

bors commented Jun 24, 2022

Copy link
Copy Markdown
Collaborator

💡 This pull request was already approved, no need to approve it again.

@bors

bors commented Jun 24, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 08789aa has been approved by RalfJung

@bors

bors commented Jun 24, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 08789aa with merge fdca237...

@bors

bors commented Jun 24, 2022

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing fdca237 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jun 24, 2022
@bors
bors merged commit fdca237 into rust-lang:masterJun 24, 2022
@rustbotrustbot added this to the 1.63.0 milestone Jun 24, 2022
@rust-highfive

rust-highfive commented Jun 24, 2022

Copy link
Copy Markdown
Contributor

📣 Toolstate changed by #98397!

Tested on commit fdca237.
Direct link to PR: #98397

🎉 miri on windows: build-fail → test-pass (cc @oli-obk@RalfJung@eddyb).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk@RalfJung@eddyb).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jun 24, 2022
@rust-highfive
📣 Toolstate changed byrust-lang/rust#98397!
00d44a2
Tested on commit rust-lang/rust@fdca237.
Direct link to PR: <rust-lang/rust#98397>
🎉 miri on windows: build-fail → test-pass (cc @oli-obk@RalfJung@eddyb).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk@RalfJung@eddyb).
@rust-timer

rust-timer commented Jun 24, 2022

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (fdca237): comparison url.

Instruction count

  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1maxcount2
Regressions 😿
(primary)		N/AN/A0
Regressions 😿
(secondary)		0.3%0.3%1
Improvements 🎉
(primary)		-0.3%-0.3%2
Improvements 🎉
(secondary)		-0.7%-0.8%6
All 😿🎉 (primary)-0.3%-0.3%2

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regression found
mean1maxcount2
Regressions 😿
(primary)		N/AN/A0
Regressions 😿
(secondary)		3.0%3.0%1
Improvements 🎉
(primary)		N/AN/A0
Improvements 🎉
(secondary)		N/AN/A0
All 😿🎉 (primary)N/AN/A0

Cycles

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regression found
mean1maxcount2
Regressions 😿
(primary)		N/AN/A0
Regressions 😿
(secondary)		4.4%4.4%1
Improvements 🎉
(primary)		N/AN/A0
Improvements 🎉
(secondary)		N/AN/A0
All 😿🎉 (primary)N/AN/A0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change↩↩2↩3

  2. number of relevant changes↩↩2↩3

@RalfJung
RalfJung deleted the miri branch June 25, 2022 12:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#98359

8 participants

@RalfJung@bors@klensy@rust-log-analyzer@ehuss@rust-highfive@rust-timer@rustbot