Skip to content

[beta] Fail gracefully when encountering an HRTB in APIT. - #98462

Merged
bors merged 2 commits into
rust-lang:betafrom
cjgillot:no-apit-hrtb-beta
Jun 26, 2022
Merged

[beta] Fail gracefully when encountering an HRTB in APIT.#98462
bors merged 2 commits into
rust-lang:betafrom
cjgillot:no-apit-hrtb-beta

Conversation

@cjgillot

@cjgillotcjgillot commented Jun 24, 2022

Copy link
Copy Markdown
Contributor

Backport of #97683
The diagnostic is a bit worse, but still better than an ICE.

r? @ehuss

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 24, 2022
@rust-highfive

rust-highfive commented Jun 24, 2022

Copy link
Copy Markdown
Contributor

⚠️Warning⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 24, 2022
@ehuss

ehuss commented Jun 24, 2022

Copy link
Copy Markdown
Contributor

LGTM.

@pietroalbini Not sure if you would prefer to pull this in with the beta promotion? Or just go ahead and merge it now?

@Mark-SimulacrumMark-Simulacrum changed the title Fail gracefully when encountering an HRTB in APIT.[beta] Fail gracefully when encountering an HRTB in APIT.Jun 26, 2022
@Mark-Simulacrum

Mark-Simulacrum commented Jun 26, 2022

Copy link
Copy Markdown
Member

@bors r+ rollup=never p=5

@bors

bors commented Jun 26, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit a081507 has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2022
@bors

bors commented Jun 26, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit a081507 with merge b6ee5a350bc7576847e18b242440ac813c05c651...

@bors

bors commented Jun 26, 2022

Copy link
Copy Markdown
Collaborator

💥 Test timed out

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 26, 2022
@rust-log-analyzer

rust-log-analyzer commented Jun 26, 2022

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

@emilyalbini

emilyalbini commented Jun 26, 2022

Copy link
Copy Markdown
Member

@bors retry

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2022
@bors

bors commented Jun 26, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit a081507 with merge 747075d...

@bors

bors commented Jun 26, 2022

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 747075d to beta...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jun 26, 2022
@bors
bors merged commit 747075d into rust-lang:betaJun 26, 2022
@rustbotrustbot added this to the 1.62.0 milestone Jun 26, 2022
@cjgillot
cjgillot deleted the no-apit-hrtb-beta branch June 27, 2022 18:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ehussehuss

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.62.0

Development

Successfully merging this pull request may close these issues.

8 participants

@cjgillot@rust-highfive@ehuss@Mark-Simulacrum@bors@rust-log-analyzer@emilyalbini@rustbot