Update measureme to the latest version by wesleywiser · Pull Request #98471 · rust-lang/rust

wesleywiser · 2022-06-24T23:38:18Z

No description provided.

rust-highfive · 2022-06-24T23:38:21Z

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

Mark-Simulacrum · 2022-06-25T02:02:54Z

@bors try @rust-timer queue

rust-timer · 2022-06-25T02:02:56Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-06-25T02:03:06Z

⌛ Trying commit 03904bbcafd24ea2ba5b3dd99ae62c9da4f83691 with merge 1542ac21c659985d94b05268c55e187570538a31...

bors · 2022-06-25T03:36:29Z

☀️ Try build successful - checks-actions
Build commit: 1542ac21c659985d94b05268c55e187570538a31 (1542ac21c659985d94b05268c55e187570538a31)

rust-timer · 2022-06-25T03:36:31Z

Queued 1542ac21c659985d94b05268c55e187570538a31 with parent fdca237, future comparison URL.

rust-timer · 2022-06-25T04:54:28Z

Finished benchmarking commit (1542ac21c659985d94b05268c55e187570538a31): comparison url.

Instruction count

Primary benchmarks: 😿 relevant regressions found
Secondary benchmarks: 😿 relevant regressions found

	mean¹	max	count²
Regressions 😿 (primary)	0.7%	1.1%	9
Regressions 😿 (secondary)	0.7%	0.8%	6
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	0.7%	1.1%	9

Max RSS (memory usage)

Results

Primary benchmarks: no relevant changes found
Secondary benchmarks: 😿 relevant regression found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	2.1%	2.1%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	N/A	N/A	0

Cycles

Results

Primary benchmarks: 😿 relevant regressions found
Secondary benchmarks: no relevant changes found

	mean¹	max	count²
Regressions 😿 (primary)	2.8%	3.0%	3
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	2.8%	3.0%	3

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

the arithmetic mean of the percent change↩↩² ↩³
number of relevant changes↩↩² ↩³

Mark-Simulacrum · 2022-06-25T15:57:55Z

@bors r+ rollup=never

bors · 2022-06-25T15:57:57Z

📌 Commit 03904bbcafd24ea2ba5b3dd99ae62c9da4f83691 has been approved by Mark-Simulacrum

bors · 2022-06-26T15:22:01Z

☔ The latest upstream changes (presumably #98518) made this pull request unmergeable. Please resolve the merge conflicts.

wesleywiser · 2022-06-27T15:12:27Z

Rebased and resolved merge conflict.

klensy · 2022-07-08T22:02:05Z

Looks like that one lost r+ on rebasing.

Mark-Simulacrum · 2022-07-23T15:37:38Z

@bors r+ rollup=never

bors · 2022-07-23T15:37:40Z

📌 Commit 6108caa has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bors · 2022-07-23T16:14:44Z

⌛ Testing commit 6108caa with merge 0e7c843...

bors · 2022-07-23T18:55:34Z

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 0e7c843 to master...

rust-timer · 2022-07-23T21:24:53Z

Finished benchmarking commit (0e7c843): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

Primary benchmarks: 🎉 relevant improvement found
Secondary benchmarks: no relevant changes found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-2.5%	-2.5%	1
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	-2.5%	-2.5%	1

Cycles

Results

Primary benchmarks: mixed results
Secondary benchmarks: no relevant changes found

	mean¹	max	count²
Regressions 😿 (primary)	3.3%	3.3%	1
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-2.6%	-2.6%	2
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	-0.6%	3.3%	3

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

the arithmetic mean of the percent change↩↩²
number of relevant changes↩↩²

rust-highfive assigned Mark-Simulacrum Jun 24, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 24, 2022

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 25, 2022

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 25, 2022

Mark-Simulacrum added the perf-regression-triaged The performance regression has been triaged. label Jun 25, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2022

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 26, 2022

wesleywiser force-pushed the update_measureme branch from 03904bb to 3f4d756Compare June 27, 2022 15:01

Update measureme to the latest version
6108caa

wesleywiser force-pushed the update_measureme branch from 3f4d756 to 6108caaCompare June 27, 2022 15:10

wesleywiser mentioned this pull request Jun 27, 2022
Use hardware performance counter data for the detailed/self-profile data view rust-lang/rustc-perf#1345
Open

wesleywiser added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 19, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 23, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 23, 2022

bors merged commit 0e7c843 into rust-lang:masterJul 23, 2022

rustbot added this to the 1.64.0 milestone Jul 23, 2022

rustbot removed the perf-regression Performance regression. label Jul 23, 2022

Uh oh!

Uh oh!

Conversation

wesleywiser commented Jun 24, 2022

Uh oh!

rust-highfive commented Jun 24, 2022

Uh oh!

Mark-Simulacrum commented Jun 25, 2022

Uh oh!

rust-timer commented Jun 25, 2022

Uh oh!

bors commented Jun 25, 2022

Uh oh!

bors commented Jun 25, 2022

Uh oh!

rust-timer commented Jun 25, 2022

Uh oh!

rust-timer commented Jun 25, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

Mark-Simulacrum commented Jun 25, 2022

Uh oh!

bors commented Jun 25, 2022

Uh oh!

bors commented Jun 26, 2022

Uh oh!

wesleywiser commented Jun 27, 2022

Uh oh!

klensy commented Jul 8, 2022

Uh oh!

Mark-Simulacrum commented Jul 23, 2022

Uh oh!

bors commented Jul 23, 2022

Uh oh!

bors commented Jul 23, 2022

Uh oh!

bors commented Jul 23, 2022

Uh oh!

rust-timer commented Jul 23, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants