Make empty bounds lower to `WellFormed` and make `WellFormed` coinductive by jackh726 · Pull Request #98542 · rust-lang/rust

jackh726 · 2022-06-26T15:10:18Z

r? rust-lang/types

jackh726 · 2022-06-26T15:10:37Z

@bors try @rust-timer queue

rust-timer · 2022-06-26T15:10:39Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-06-26T15:10:46Z

⌛ Trying commit 17fc375eb17df1e939ac23d2297f0642e1cfa6dd with merge c078f423e8387b6d48de9e764d99dfefb7a083e4...

bors · 2022-06-26T16:45:27Z

☀️ Try build successful - checks-actions
Build commit: c078f423e8387b6d48de9e764d99dfefb7a083e4 (c078f423e8387b6d48de9e764d99dfefb7a083e4)

rust-timer · 2022-06-26T16:45:28Z

Queued c078f423e8387b6d48de9e764d99dfefb7a083e4 with parent 7125846, future comparison URL.

rust-timer · 2022-06-26T17:50:30Z

Finished benchmarking commit (c078f423e8387b6d48de9e764d99dfefb7a083e4): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

Primary benchmarks: mixed results
Secondary benchmarks: no relevant changes found

	mean¹	max	count²
Regressions 😿 (primary)	2.6%	2.6%	1
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-3.7%	-4.0%	2
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	-1.6%	-4.0%	3

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

the arithmetic mean of the percent change↩
number of relevant changes↩

oli-obk · 2022-06-27T06:44:09Z

Maybe run perf on that first so we can replace the very likely with been shown

Ehh, I would prefer to not try to make that change right now (because it's going to take some time to do right - which is limited for me right now - and I think the time will just be wasted).

oli-obk · 2022-06-28T06:24:39Z

@bors r+

bors · 2022-06-28T06:24:41Z

📌 Commit bd298ad has been approved by oli-obk

bors · 2022-06-29T03:22:50Z

⌛ Testing commit bd298ad with merge 116edb6...

bors · 2022-06-29T05:47:34Z

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 116edb6 to master...

rust-timer · 2022-06-29T07:15:48Z

Finished benchmarking commit (116edb6): comparison url.

Instruction count

Primary benchmarks: no relevant changes found
Secondary benchmarks: 🎉 relevant improvements found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-0.6%	-0.7%	6
All 😿🎉 (primary)	N/A	N/A	0

Max RSS (memory usage)

Results

Primary benchmarks: mixed results
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions 😿 (primary)	5.1%	5.1%	1
Regressions 😿 (secondary)	2.5%	3.8%	2
Improvements 🎉 (primary)	-2.0%	-2.0%	1
Improvements 🎉 (secondary)	-3.6%	-3.6%	1
All 😿🎉 (primary)	1.5%	5.1%	2

Cycles

Results

Primary benchmarks: 🎉 relevant improvement found
Secondary benchmarks: 😿 relevant regression found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	2.3%	2.3%	1
Improvements 🎉 (primary)	-3.3%	-3.3%	1
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	-3.3%	-3.3%	1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

the arithmetic mean of the percent change↩↩² ↩³
number of relevant changes↩↩² ↩³

…lcnr Make well-formedness predicates no longer coinductive This PR makes well-formedness no longer coinductive. It was made coinductive in rust-lang#98542, but AFAICT this was only to fix UI tests since we stopped lowering `where Ty:` to an empty-region outlives predicate but to a WF predicate instead. Arguably it should lower to something completely different, something like a "type mentioned no-op predicate", but well-formedness serves this purpose fine today, and since no code (according to crater) relies on this coinductive behavior, we'd like to avoid having to emulate it in the new solver. Fixesrust-lang#123456 (I didn't want to add a test since it seems low-value to have a ICE test for a fuzzer minimization that is basically garbage code.) Fixes #109764 (not sure if this behavior is emulatable w/o coinductive WF?) Fixesrust-lang/trait-system-refactor-initiative#169 r? lcnr

Rollup merge of rust-lang#140208 - compiler-errors:wf-coinductive, r=lcnr Make well-formedness predicates no longer coinductive This PR makes well-formedness no longer coinductive. It was made coinductive in rust-lang#98542, but AFAICT this was only to fix UI tests since we stopped lowering `where Ty:` to an empty-region outlives predicate but to a WF predicate instead. Arguably it should lower to something completely different, something like a "type mentioned no-op predicate", but well-formedness serves this purpose fine today, and since no code (according to crater) relies on this coinductive behavior, we'd like to avoid having to emulate it in the new solver. Fixesrust-lang#123456 (I didn't want to add a test since it seems low-value to have a ICE test for a fuzzer minimization that is basically garbage code.) Fixes #109764 (not sure if this behavior is emulatable w/o coinductive WF?) Fixesrust-lang/trait-system-refactor-initiative#169 r? lcnr

rust-highfive assigned oli-obk Jun 26, 2022

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 26, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 26, 2022

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 26, 2022

This comment has been minimized.
Sign in to view

jackh726 force-pushed the coinductive-wf branch from 17fc375 to 5fc48bbCompare June 26, 2022 17:49

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 26, 2022

jackh726 mentioned this pull request Jun 27, 2022
Remove ReEmpty #98559
Merged

oli-obk reviewed Jun 27, 2022
View reviewed changes

Comment threadcompiler/rustc_traits/src/chalk/lowering.rs Outdated

oli-obk reviewed Jun 27, 2022
View reviewed changes

jackh726 added 2 commits June 28, 2022 00:17

Make empty bounds lower to WellFormed and make WellFormed coinductive
e16dbb5

Take into account trait predicate coinductiveness
bd298ad

jackh726 force-pushed the coinductive-wf branch from 89cf01a to bd298adCompare June 28, 2022 04:18

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 29, 2022

bors merged commit 116edb6 into rust-lang:masterJun 29, 2022

rustbot added this to the 1.64.0 milestone Jun 29, 2022

bors mentioned this pull request Jun 29, 2022
rewrite ensure_drop_predicates_are_implied_by_item_defn#97326
Closed

jackh726 deleted the coinductive-wf branch June 29, 2022 13:09

compiler-errors mentioned this pull request Aug 15, 2022
Regression evaluating impl bounds with generic_const_exprs#100553
Open

jruderman mentioned this pull request Oct 30, 2022
Hang with ADT const param, self-mention in where clause #103770
Closed

compiler-errors mentioned this pull request Apr 29, 2025
Make well-formedness predicates no longer coinductive #140208
Merged

Uh oh!

Uh oh!

Conversation

jackh726 commented Jun 26, 2022

Uh oh!

jackh726 commented Jun 26, 2022

Uh oh!

rust-timer commented Jun 26, 2022

Uh oh!

bors commented Jun 26, 2022

Uh oh!

This comment has been minimized.

bors commented Jun 26, 2022

Uh oh!

rust-timer commented Jun 26, 2022

Uh oh!

rust-timer commented Jun 26, 2022

Footnotes

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oli-obk commented Jun 28, 2022

Uh oh!

bors commented Jun 28, 2022

Uh oh!

bors commented Jun 29, 2022

Uh oh!

bors commented Jun 29, 2022

Uh oh!

rust-timer commented Jun 29, 2022

Footnotes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants