Uh oh!
There was an error while loading. Please reload this page.
Fix box with custom allocator in miri - #98554
Merged
Merged
Conversation
rust-highfive
commented
Jun 26, 2022
Contributor
Some changes occured to the CTFE / Miri engine cc @rust-lang/miri |
rust-highfive
commented
Jun 26, 2022
Contributor
(rust-highfive has picked a reviewer for you, use r? to override) |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
RalfJung
commented
Jun 26, 2022
Member
r? @RalfJung |
rustbot
commented
Jun 28, 2022
Collaborator
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri |
This comment has been minimized.
This comment has been minimized.
Uh oh!
There was an error while loading. Please reload this page.
you should always run x.py check before pushing
RalfJung
commented
Jun 28, 2022
Member
Looking good, very nice. :) |
bors
commented
Jun 28, 2022
Collaborator
📌 Commit 9039265 has been approved by |
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jun 29, 2022
…ial, r=RalfJung Fix box with custom allocator in miri This should fix the failures in rust-lang/miri#2072 and rust-lang#98510. cc `@RalfJung`
Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jun 29, 2022
…ial, r=RalfJung Fix box with custom allocator in miri This should fix the failures in rust-lang/miri#2072 and rust-lang#98510. cc ``@RalfJung``
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 29, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#98415 (Migrate some `rustc_borrowck` diagnostics to `SessionDiagnostic`) - rust-lang#98479 (Add `fetch_not` method on `AtomicBool`) - rust-lang#98499 (Erase regions in New Abstract Consts) - rust-lang#98516 (library: fix uefi va_list type definition) - rust-lang#98554 (Fix box with custom allocator in miri) - rust-lang#98607 (Clean up arg mismatch diagnostic, generalize tuple wrap suggestion) - rust-lang#98625 (emit Retag for compound types with reference fields) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 4, 2022
fix interpreter validity check on Box Follow-up to rust-lang#98554: avoid walking over parts of the value twice. And then move all that logic into the general visitor so not each visitor implementation has to deal with it...
Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 4, 2022
fix interpreter validity check on Box Follow-up to rust-lang#98554: avoid walking over parts of the value twice. And then move all that logic into the general visitor so not each visitor implementation has to deal with it...
Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 4, 2022
fix interpreter validity check on Box Follow-up to rust-lang#98554: avoid walking over parts of the value twice. And then move all that logic into the general visitor so not each visitor implementation has to deal with it...
Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 5, 2022
fix interpreter validity check on Box Follow-up to rust-lang#98554: avoid walking over parts of the value twice. And then move all that logic into the general visitor so not each visitor implementation has to deal with it...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the failures in rust-lang/miri#2072 and #98510.
cc @RalfJung