Skip to content

Migrate some diagnostics from rustc_const_eval to SessionDiagnostic - #98657

Merged
bors merged 8 commits into
rust-lang:masterfrom
compiler-errors:rustc-const-eval-session-diagnostic-1
Jul 8, 2022
Merged

Migrate some diagnostics from rustc_const_eval to SessionDiagnostic#98657
bors merged 8 commits into
rust-lang:masterfrom
compiler-errors:rustc-const-eval-session-diagnostic-1

Conversation

@compiler-errors

@compiler-errorscompiler-errors commented Jun 29, 2022

Copy link
Copy Markdown
Contributor

I'm still trying to get the hang of this, so it doesn't migrate all of rustc_const_eval. Working on that later.

r? @davidtwco

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 29, 2022
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 29, 2022
@compiler-errors
compiler-errorsforce-pushed the rustc-const-eval-session-diagnostic-1 branch from 4605a17 to 4dd984cCompareJune 29, 2022 07:07
davidtwco
davidtwco approved these changes Jun 29, 2022
View reviewed changes

@davidtwcodavidtwco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, a couple small comments.

Comment threadcompiler/rustc_const_eval/src/lib.rs Outdated
Comment threadcompiler/rustc_macros/src/diagnostics/fluent.rs Outdated
Comment threadcompiler/rustc_error_messages/locales/en-US/const_eval.ftl Outdated
Comment threadcompiler/rustc_hir/src/hir.rs Outdated
Comment threadsrc/test/ui-fulldeps/session-diagnostic/diagnostic-derive.stderr Outdated
@bors

This comment was marked as resolved.

Sign in to view
@compiler-errors
compiler-errorsforce-pushed the rustc-const-eval-session-diagnostic-1 branch from 4dd984c to 2058333CompareJuly 8, 2022 03:52
@compiler-errors

compiler-errors commented Jul 8, 2022

Copy link
Copy Markdown
ContributorAuthor

@rustbot ready :)

@rustbot

This comment was marked as resolved.

Sign in to view
@compiler-errors

compiler-errors commented Jul 8, 2022

Copy link
Copy Markdown
ContributorAuthor

lmao

@rustbot ready

@davidtwco

davidtwco commented Jul 8, 2022

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Jul 8, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 2058333 has been approved by davidtwco

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 8, 2022
@Dylan-DPCDylan-DPC mentioned this pull request Jul 8, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 8, 2022
@bors
Auto merge ofrust-lang#99054- Dylan-DPC:rollup-0zuhhds, r=Dylan-DPC
45263fc
Rollup of 4 pull requests
Successful merges:
- rust-lang#98533 (Add a `-Zdump-drop-tracking-cfg` debugging flag)
- rust-lang#98654 (An optimization for `pest-2.1.3`)
- rust-lang#98657 (Migrate some diagnostics from `rustc_const_eval` to `SessionDiagnostic`)
- rust-lang#98794 (Highlight conflicting param-env candidates)
Failed merges:
- rust-lang#98957 ( don't allow ZST in ScalarInt )
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit dbae830 into rust-lang:masterJul 8, 2022
@rustbotrustbot added this to the 1.64.0 milestone Jul 8, 2022
@lqdlqd mentioned this pull request Jul 15, 2022
Closed
@davidtwcodavidtwco added the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Aug 17, 2022
@compiler-errors
compiler-errors deleted the rustc-const-eval-session-diagnostic-1 branch August 11, 2023 20:19
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidtwcodavidtwcodavidtwco approved these changes

Assignees

@davidtwcodavidtwco

Labels

A-translationArea: Translation infrastructure, and migrating existing diagnostics to SessionDiagnosticS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.64.0

Development

Successfully merging this pull request may close these issues.

5 participants

@compiler-errors@bors@rustbot@davidtwco@rust-highfive