Uh oh!
There was an error while loading. Please reload this page.
Patch to error and fail instead of using all available memory - #987
Patch to error and fail instead of using all available memory#987wmealing wants to merge 1 commit into
Conversation
then crashing to detect the error condition of an unmatched double quote before the end of a file. I couldn't get it to show nice error messages, so this may not be the ideal fix. A test case for this situation has also been added.
brson
commented
Sep 27, 2011
Hi. This looks great! As I believe this is your first contribution to Rust (huzzah!), we need to make sure the paperwork is in order (sigh). Fortunately it's really simple. If you already have level 1 committer access with Mozilla then you're good to go. Otherwise please submit a committer agreement[1], which is mostly just a legal paper trail asserting that you wrote the code. Let me know when you've done that and I will get this merged. [1] http://www.mozilla.org/hacking/notification/. Note that there's no need to request level 1 committer access for contributing to Rust - we just need the signed agreement. |
wmealing
commented
Sep 28, 2011
Email sent and "signed". I didn't think that this method of development required commit access so I just followed the page specifically as per your instructions. |
There was a problem hiding this comment.
This may show quite a lot of data if the first quote is early in the source code.
There was a problem hiding this comment.
Very true. Sadly we have many errors that spew pages of garbage. If you want to provide a follow-up patch that makes it more sane, that would be fine.
brson
commented
Sep 28, 2011
OK. When we get notice that you're agreement is received I'll pull this. Thanks for being patient. |
brson
commented
Sep 28, 2011
Integrated. |
987: Refactor maybe_item to use Marker argument r=pcpthm a=pcpthm As suggested at <rust-lang/rust-analyzer#980 (comment)>. For expression paring functions, changing signature - from `fn(&mut Parser) -> Option<CompletedMarker>` to `fn(&mut Parser, Marker) -> Result<CompletedMarker, Marker>` - from `fn(&mut Parser) -> CompletedMarker` to `fn(&mut Parser, Marker) -> CompletedMarker` is my plan. Co-authored-by: pcpthm <pcpthm@gmail.com>
…ags, r=RalfJung Error when there is an unsupported flag for opening a file @RalfJung this is my attempt to check for undesired flags. I also changed fcntl to error when doing any other action besides getting the flags for a fd
then crashing to detect the error condition of an unmatched
double quote before the end of a file.
I couldn't get it to show nice error messages, so this may not be
the ideal fix.
A test case for this situation has also been added.
I have made a pull request, but unsure if its the correct way of showing errors, feel free to change it.