Uh oh!
There was an error while loading. Please reload this page.
cleanup mir visitor for rustc::pass_by_value - #98766
Merged
Merged
Conversation
rustbot
commented
Jul 1, 2022
Collaborator
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rust-highfive
commented
Jul 1, 2022
Contributor
r? @wesleywiser (rust-highfive has picked a reviewer for you, use r? to override) |
oli-obk
approved these changes
Jul 1, 2022
oli-obk
left a comment
Contributor
There was a problem hiding this comment.
None of my comments should be applied in this PR, there's probably many more that could be addressed that way.
r=me with CI happy
| fn visit_ascribe_user_ty( | ||
| &mut self, | ||
| place: & $($mutability)? Place<'tcx>, | ||
| variance: & $($mutability)? ty::Variance, |
Contributor
There was a problem hiding this comment.
variance is a trivial enum and could benefit from this, too
| location: Location) { | ||
| fn visit_ascribe_user_ty( | ||
| &mut self, | ||
| place: & $($mutability)? Place<'tcx>, |
Contributor
There was a problem hiding this comment.
place small, so passing them by value should be ok (two ptr-sized things instead of one)
| location: Location) { | ||
| fn visit_retag( | ||
| &mut self, | ||
| kind: & $($mutability)? RetagKind, |
Contributor
There was a problem hiding this comment.
also a trivial enum that could be passed by value.. although it isn't Copy, maybe that's just an oversight?
Dylan-DPC
commented
Jul 1, 2022
Member
@bors r=oli-obk |
bors
commented
Jul 1, 2022
Collaborator
📌 Commit cf9c0a5 has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 2, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#98639 (Factor out `hir::Node::Binding`) - rust-lang#98653 (Add regression test for rust-lang#79494) - rust-lang#98763 (bootstrap: illumos platform flags for split-debuginfo) - rust-lang#98766 (cleanup mir visitor for `rustc::pass_by_value`) - rust-lang#98783 (interpret: make a comment less scary) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 4, 2022
…i-obk add more `rustc_pass_by_value` r? `@oli-obk` cc rust-lang#98766
Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 4, 2022
…i-obk add more `rustc_pass_by_value` r? ``@oli-obk`` cc rust-lang#98766
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 4, 2022
…i-obk add more `rustc_pass_by_value` r? ```@oli-obk``` cc rust-lang#98766
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by changing
& $($mutability)?to$(& $mutability)?I also did some formatting changes because I started doing them for the visit methods I changed and then couldn't get myself to stop xx, I hope that's still fairly easy to review.