Skip to content

rustdoc: make source sidebar toggle a real button - #98774

Merged
bors merged 4 commits into
rust-lang:masterfrom
notriddle:notriddle/source-code-sidebar-button
Jul 4, 2022
Merged

rustdoc: make source sidebar toggle a real button#98774
bors merged 4 commits into
rust-lang:masterfrom
notriddle:notriddle/source-code-sidebar-button

Conversation

@notriddle

@notriddlenotriddle commented Jul 1, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

This fixes tab focus, so that you can open and close the sidebar from keyboard.

This should cause no visible change in appearance at all. The only way you'd know anything different is if you tried to use keyboard controls to open the source code file navigation sidebar.

Separated out from #98772

@rustbotrustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jul 1, 2022
@rustbot

rustbot commented Jul 1, 2022

Copy link
Copy Markdown
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

Some changes occurred in HTML/CSS themes.

cc @GuillaumeGomez

A change occurred in the Ayu theme.

cc @Cldfire

@rust-highfive

rust-highfive commented Jul 1, 2022

Copy link
Copy Markdown
Contributor

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 1, 2022
@notriddle

notriddle commented Jul 1, 2022

Copy link
Copy Markdown
ContributorAuthor

r? @GuillaumeGomez

GuillaumeGomez
GuillaumeGomez reviewed Jul 1, 2022
View reviewed changes
Comment threadsrc/librustdoc/html/static/css/rustdoc.css Outdated
@GuillaumeGomez

GuillaumeGomez commented Jul 1, 2022

Copy link
Copy Markdown
Member

Since you added the possibility to focus on the button, can you add a GUI test for it please?

@notriddle
notriddleforce-pushed the notriddle/source-code-sidebar-button branch from 7afc6db to 0d8974bCompareJuly 1, 2022 21:57
@notriddle

notriddle commented Jul 1, 2022

Copy link
Copy Markdown
ContributorAuthor

@GuillaumeGomez

Since you added the possibility to focus on the button, can you add a GUI test for it please?

Okay, test case added.

@bors

bors commented Jul 2, 2022

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #98781) made this pull request unmergeable. Please resolve the merge conflicts.

@GuillaumeGomez

GuillaumeGomez commented Jul 2, 2022

Copy link
Copy Markdown
Member

Looks good to me, thanks! Please fix the merge conflict then I'll make a final review before approving it.

@notriddle
notriddleforce-pushed the notriddle/source-code-sidebar-button branch from cbdf33a to 26dccbfCompareJuly 2, 2022 15:45
@notriddle

notriddle commented Jul 2, 2022

Copy link
Copy Markdown
ContributorAuthor

@GuillaumeGomez Okay, I've rebased it.

GuillaumeGomez
GuillaumeGomez reviewed Jul 3, 2022
View reviewed changes
Comment threadsrc/librustdoc/html/static/css/rustdoc.css Outdated
}

#sidebar-toggle:hover {
#sidebar-toggle > button:hover:hover, #sidebar-toggle > button:focus {

@GuillaumeGomezGuillaumeGomezJul 3, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:hover:hover? 😉

@notriddlenotriddleJul 3, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

Pushed commit to fix that.

@GuillaumeGomez

GuillaumeGomez commented Jul 3, 2022

Copy link
Copy Markdown
Member

Thanks!

@bors r+ rollup

@bors

bors commented Jul 3, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 9938d56 has been approved by GuillaumeGomez

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2022
@matthiaskrgrmatthiaskrgr mentioned this pull request Jul 4, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 4, 2022
@bors
Auto merge ofrust-lang#98874- matthiaskrgr:rollup-0u4hm54, r=matthi…
9c9ae85
…askrgr
Rollup of 5 pull requests
Successful merges:
- rust-lang#98501 (rustc_passes/src/entry.rs: De-duplicate more code with `fn throw_attr_err()`)
- rust-lang#98774 (rustdoc: make source sidebar toggle a real button)
- rust-lang#98806 (Fix long declaration trailing whitespace)
- rust-lang#98823 (Fix rust-call ICE in mir-inliner)
- rust-lang#98870 (Add regression test for rust-lang#86784)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 47456ad into rust-lang:masterJul 4, 2022
@rustbotrustbot added this to the 1.64.0 milestone Jul 4, 2022
@notriddle
notriddle deleted the notriddle/source-code-sidebar-button branch September 21, 2023 19:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomezGuillaumeGomezGuillaumeGomez approved these changes

Assignees

@GuillaumeGomezGuillaumeGomez

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.64.0

Development

Successfully merging this pull request may close these issues.

5 participants

@notriddle@rustbot@rust-highfive@GuillaumeGomez@bors