Skip to content

suggest adding a derive for #[default] applied to variants - #99002

Merged
bors merged 1 commit into
rust-lang:masterfrom
fee1-dead-contrib:sugg_derive
Jul 7, 2022
Merged

suggest adding a derive for #[default] applied to variants#99002
bors merged 1 commit into
rust-lang:masterfrom
fee1-dead-contrib:sugg_derive

Conversation

@fee1-dead

Copy link
Copy Markdown
Member

cc @TaKO8Ki as followup to #98873.

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 7, 2022
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @michaelwoerister

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 7, 2022
@michaelwoerister

Copy link
Copy Markdown
Member

Looks good to me. Thanks, @fee1-dead!

@bors r+ rollup

@bors

bors commented Jul 7, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 2f0ccdf has been approved by michaelwoerister

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 7, 2022
…chaelwoerister
suggest adding a derive for #[default] applied to variants
cc `@TaKO8Ki` as followup to rust-lang#98873.
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 7, 2022
…askrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#97917 (Implement ExitCodeExt for Windows)
- rust-lang#98844 (Reword comments and rename HIR visiting methods.)
- rust-lang#98979 (interpret: use AllocRange in UninitByteAccess)
- rust-lang#98986 (Fix missing word in comment)
- rust-lang#98994 (replace process exit with more detailed exit in src/bootstrap/*.rs)
- rust-lang#98995 (Add a test for rust-lang#80471)
- rust-lang#99002 (suggest adding a derive for #[default] applied to variants)
- rust-lang#99004 (Add a test for rust-lang#70408)
- rust-lang#99017 (Replace boolean argument for print_where_clause with an enum to make code more clear)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 7fed4ff into rust-lang:masterJul 7, 2022
@rustbotrustbot added this to the 1.64.0 milestone Jul 7, 2022
@fee1-dead
fee1-dead deleted the sugg_derive branch November 9, 2022 12:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@fee1-dead@rust-highfive@michaelwoerister@bors@TaKO8Ki@rustbot