Skip to content

Document and stabilize process_set_process_group - #99088

Merged
bors merged 2 commits into
rust-lang:masterfrom
niklasf:stabilize-process_set_process_group
Jul 17, 2022
Merged

Document and stabilize process_set_process_group#99088
bors merged 2 commits into
rust-lang:masterfrom
niklasf:stabilize-process_set_process_group

Conversation

@niklasf

@niklasfniklasf commented Jul 9, 2022

Copy link
Copy Markdown
Contributor

Tracking issue: #93857

FCP finished here: #93857 (comment)

@rustbot

rustbot commented Jul 9, 2022

Copy link
Copy Markdown
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbotrustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jul 9, 2022
@rust-highfive

rust-highfive commented Jul 9, 2022

Copy link
Copy Markdown
Contributor

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 9, 2022
@niklasf

niklasf commented Jul 9, 2022

Copy link
Copy Markdown
ContributorAuthor

@rustbot label +T-libs-api -T-libs

@rustbotrustbot added T-libs-api [DEPRECATED; DO NOT USE] and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 9, 2022
joshtriplett
joshtriplett reviewed Jul 16, 2022
View reviewed changes
Comment threadlibrary/std/src/os/unix/process.rs Outdated
joshtriplett
joshtriplett reviewed Jul 16, 2022
View reviewed changes
Comment threadlibrary/std/src/os/unix/process.rs
@joshtriplett
Expand documentation for process_group
629b0b4
Explain PGID 0, and provide the acronym PGID.
@joshtriplettjoshtriplett added the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 16, 2022
@joshtriplett

joshtriplett commented Jul 16, 2022

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Jul 16, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 629b0b4 has been approved by joshtriplett

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2022
@JohnTitorJohnTitor mentioned this pull request Jul 17, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 17, 2022
@bors
Auto merge ofrust-lang#99362- JohnTitor:rollup-4d5zo9d, r=JohnTitor
1cd72b7
Rollup of 7 pull requests
Successful merges:
- rust-lang#94927 (Stabilize `let_chains` in Rust 1.64)
- rust-lang#97915 (Implement `fmt::Write` for `OsString`)
- rust-lang#99036 (Add `#[test]` to functions in test modules)
- rust-lang#99088 (Document and stabilize process_set_process_group)
- rust-lang#99302 (add tracking issue to generic member access APIs)
- rust-lang#99306 (Stabilize `future_poll_fn`)
- rust-lang#99354 (Add regression test for rust-lang#95829)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit f49d267 into rust-lang:masterJul 17, 2022
@rustbotrustbot added this to the 1.64.0 milestone Jul 17, 2022
@JohnTitorJohnTitor mentioned this pull request Jul 18, 2022
Closed
4 tasks
@ipetkovipetkov mentioned this pull request Jul 27, 2022
Closed
@niklasf
niklasf deleted the stabilize-process_set_process_group branch June 21, 2026 20:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshtriplettjoshtriplettjoshtriplett left review comments

Assignees

@joshtriplettjoshtriplett

Labels

relnotesMarks issues that should be documented in the release notes of the next release.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

1.64.0

Development

Successfully merging this pull request may close these issues.

5 participants

@niklasf@rustbot@rust-highfive@joshtriplett@bors