Skip to content

Stabilize core::ffi::CStr, alloc::ffi::CString, and friends - #99277

Merged
bors merged 1 commit into
rust-lang:masterfrom
joshtriplett:stabilize-core-cstr-alloc-cstring
Jul 16, 2022
Merged

Stabilize core::ffi::CStr, alloc::ffi::CString, and friends#99277
bors merged 1 commit into
rust-lang:masterfrom
joshtriplett:stabilize-core-cstr-alloc-cstring

Conversation

@joshtriplett

@joshtriplettjoshtriplett commented Jul 15, 2022

Copy link
Copy Markdown
Member

Stabilize the core_c_str and alloc_c_string feature gates.

Change std::ffi to re-export these types rather than creating type
aliases, since they now have matching stability.

@joshtriplett
Stabilize core::ffi::CStr, alloc::ffi::CString, and friends
d6b7480
Stabilize the `core_c_str` and `alloc_c_string` feature gates.
Change `std::ffi` to re-export these types rather than creating type
aliases, since they now have matching stability.
@rustbot

rustbot commented Jul 15, 2022

Copy link
Copy Markdown
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive

rust-highfive commented Jul 15, 2022

Copy link
Copy Markdown
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 15, 2022
@joshtriplettjoshtriplett added T-libs-api [DEPRECATED; DO NOT USE] relnotes Marks issues that should be documented in the release notes of the next release. labels Jul 15, 2022
@joshtriplett

joshtriplett commented Jul 15, 2022

Copy link
Copy Markdown
MemberAuthor

FCP to stabilize completed in #98314 .

@Mark-Simulacrum

Mark-Simulacrum commented Jul 15, 2022

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Jul 15, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit d6b7480 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2022
@JohnTitorJohnTitor mentioned this pull request Jul 16, 2022
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jul 16, 2022
@JohnTitor
Rollup merge ofrust-lang#99277- joshtriplett:stabilize-core-cstr-al…
512922a
…loc-cstring, r=Mark-Simulacrum
Stabilize `core::ffi::CStr`, `alloc::ffi::CString`, and friends
Stabilize the `core_c_str` and `alloc_c_string` feature gates.
Change `std::ffi` to re-export these types rather than creating type
aliases, since they now have matching stability.
@JohnTitorJohnTitor mentioned this pull request Jul 16, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 16, 2022
@bors
Auto merge ofrust-lang#99315- JohnTitor:rollup-77wzoc1, r=JohnTitor
7210e46
Rollup of 7 pull requests
Successful merges:
- rust-lang#98387 (Add new unstable API `downcast` to `std::io::Error`)
- rust-lang#98662 (Add std::fs::write documentation precision)
- rust-lang#99253 (Remove FIXME from MIR `always_storage_live_locals`)
- rust-lang#99264 (Fix typo in mod.rs)
- rust-lang#99270 (Add `#[must_use]` to `Box::from_raw`)
- rust-lang#99277 (Stabilize `core::ffi::CStr`, `alloc::ffi::CString`, and friends)
- rust-lang#99307 (Add regression test for rust-lang#64401)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 083a253 into rust-lang:masterJul 16, 2022
@rustbotrustbot added this to the 1.64.0 milestone Jul 16, 2022
@joshtriplettjoshtriplett mentioned this pull request Jul 16, 2022
Closed
3 tasks
This was referenced Jul 19, 2022
Open
Closed
@upsuperupsuper mentioned this pull request Aug 6, 2022
Closed
@i509VCBi509VCB mentioned this pull request Aug 17, 2022
Open
@rzezeskirzezeski mentioned this pull request Sep 26, 2022
Closed
@kkysenkkysen mentioned this pull request Dec 7, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

relnotesMarks issues that should be documented in the release notes of the next release.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

1.64.0

Development

Successfully merging this pull request may close these issues.

5 participants

@joshtriplett@rustbot@rust-highfive@Mark-Simulacrum@bors