Uh oh!
There was an error while loading. Please reload this page.
Mark stabilized intrinsics with rustc_allowed_through_unstable_modules - #99288
Conversation
Fixesrust-lang#99286 PR rust-lang#95956 accidentally made these intrinsics unstable when accessed through the unstable path segment 'std::intrinsics'
rustbot
commented
Jul 15, 2022
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
rust-highfive
commented
Jul 15, 2022
(rust-highfive has picked a reviewer for you, use r? to override) |
Aaron1011
commented
Jul 15, 2022
0ba18e4 to
ef8e322CompareSkiFire13
commented
Jul 15, 2022
In that PR there was a crater run and the regressions were identified, but never discussed. |
yaahc
commented
Jul 15, 2022
Oof, ty for catching that, as @SkiFire13 pointed out I reviewed the crater run and identified all of the APIs that needed that attribute and I did the work to add support for that attribute, but when I came back to the PR to finish the last steps I mistakenly remembered having already added those attributes and didn't carefully re-read my own diff 🤦♀️ . |
Aaron1011
commented
Jul 15, 2022
This is affecting several repositories - can we get this merged today, so that it makes it into the next nightly? |
yaahc
commented
Jul 15, 2022
Oh, of course, thank you for the reminder. For some reason I was thinking this had to be approved by compiler and not libs, feeling bit scatter brained today >_< @bors r+ |
bors
commented
Jul 15, 2022
Mark-Simulacrum
commented
Jul 15, 2022
@bors p=5 |
bors
commented
Jul 15, 2022
bors
commented
Jul 16, 2022
☀️ Test successful - checks-actions |
rust-timer
commented
Jul 16, 2022
Finished benchmarking commit (8c1cc82): comparison url. Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
Fixes#99286
PR #95956 accidentally made these intrinsics unstable when
accessed through the unstable path segment 'std::intrinsics'