Skip to content

Use LocalDefId in OpaqueTypeKey - #99347

Merged
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:opaque-type-key-local-def-id
Jul 19, 2022
Merged

Use LocalDefId in OpaqueTypeKey#99347
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:opaque-type-key-local-def-id

Conversation

@compiler-errors

Copy link
Copy Markdown
Contributor

Addresses a // FIXME(oli-obk): make this a LocalDefId

r? @oli-obk

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 16, 2022
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 16, 2022
@oli-obk

Copy link
Copy Markdown
Contributor

@bors r+

Thanks!

@bors

bors commented Jul 17, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit b631983 has been approved by oli-obk

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2022
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jul 17, 2022
…al-def-id, r=oli-obk
Use `LocalDefId` in `OpaqueTypeKey`
Addresses a `// FIXME(oli-obk): make this a LocalDefId`
r? `@oli-obk`
@JohnTitorJohnTitor mentioned this pull request Jul 17, 2022
@Dylan-DPCDylan-DPC mentioned this pull request Jul 18, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jul 18, 2022
…al-def-id, r=oli-obk
Use `LocalDefId` in `OpaqueTypeKey`
Addresses a `// FIXME(oli-obk): make this a LocalDefId`
r? ```@oli-obk```
@Dylan-DPCDylan-DPC mentioned this pull request Jul 18, 2022
@Dylan-DPC

Copy link
Copy Markdown
Member

failed in rollup ci

@Dylan-DPC

Copy link
Copy Markdown
Member

@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 18, 2022
@compiler-errors
compiler-errorsforce-pushed the opaque-type-key-local-def-id branch from b631983 to 136f017CompareJuly 19, 2022 02:09
@compiler-errors

Copy link
Copy Markdown
ContributorAuthor

@bors r=oli-obk

@bors

bors commented Jul 19, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 136f017 has been approved by oli-obk

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 19, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jul 19, 2022
…al-def-id, r=oli-obk
Use `LocalDefId` in `OpaqueTypeKey`
Addresses a `// FIXME(oli-obk): make this a LocalDefId`
r? `@oli-obk`
This was referenced Jul 19, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 19, 2022
Rollup of 8 pull requests
Successful merges:
- rust-lang#97183 (wf-check generators)
- rust-lang#98320 (Mention first and last macro in backtrace)
- rust-lang#99335 (Use split_once in FromStr docs)
- rust-lang#99347 (Use `LocalDefId` in `OpaqueTypeKey`)
- rust-lang#99392 (Fix debuginfo tests.)
- rust-lang#99404 (Use span_bug for unexpected field projection type)
- rust-lang#99410 (Update invalid atomic ordering lint)
- rust-lang#99434 (Fix `Skip::next` for non-fused inner iterators)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit d00646b into rust-lang:masterJul 19, 2022
@rustbotrustbot added this to the 1.64.0 milestone Jul 19, 2022
@compiler-errors
compiler-errors deleted the opaque-type-key-local-def-id branch August 11, 2023 20:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@compiler-errors@oli-obk@bors@Dylan-DPC@rust-highfive@rustbot