Revert Allow destructuring opaque types in their defining scopes by matthiaskrgr · Pull Request #99368 · rust-lang/rust

matthiaskrgr · 2022-07-17T09:47:45Z

reverts PR #98582

This reverts commit 6f8fb91, reversing
changes made to 7210e46.

r? @ghost

…e_type, r=estebank" This reverts commit 6f8fb91, reversing changes made to 7210e46.

rustbot · 2022-07-17T09:47:48Z

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

matthiaskrgr · 2022-07-17T09:48:10Z

@bors try @rust-timer queue

rust-timer · 2022-07-17T09:48:12Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

matthiaskrgr · 2022-07-17T09:49:02Z

Ouff sorry for all the pings, is there a way to make rustbot not do that? :/

bors · 2022-07-17T10:41:06Z

⌛ Trying commit 63d3cea with merge f3aa1baa95ecd1fed574085c44f597a1de226da5...

bors · 2022-07-17T12:31:34Z

☀️ Try build successful - checks-actions
Build commit: f3aa1baa95ecd1fed574085c44f597a1de226da5 (f3aa1baa95ecd1fed574085c44f597a1de226da5)

rust-timer · 2022-07-17T12:31:36Z

Queued f3aa1baa95ecd1fed574085c44f597a1de226da5 with parent 1cd72b7, future comparison URL.

rust-timer · 2022-07-17T18:45:34Z

Finished benchmarking commit (f3aa1baa95ecd1fed574085c44f597a1de226da5): comparison url.

Instruction count

Primary benchmarks: 🎉 relevant improvements found
Secondary benchmarks: 🎉 relevant improvements found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-0.6%	-2.5%	123
Improvements 🎉 (secondary)	-1.0%	-5.5%	84
All 😿🎉 (primary)	-0.6%	-2.5%	123

Max RSS (memory usage)

Results

Primary benchmarks: 🎉 relevant improvements found
Secondary benchmarks: no relevant changes found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-1.1%	-1.3%	2
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	-1.1%	-1.3%	2

Cycles

Results

Primary benchmarks: 🎉 relevant improvements found
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	12.9%	12.9%	1
Improvements 🎉 (primary)	-2.1%	-2.3%	6
Improvements 🎉 (secondary)	-2.7%	-3.8%	10
All 😿🎉 (primary)	-2.1%	-2.3%	6

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

the arithmetic mean of the percent change↩↩² ↩³
number of relevant changes↩↩² ↩³

oli-obk · 2022-07-18T06:49:12Z

r? @oli-obk

oli-obk · 2022-07-18T06:49:38Z

@bors r+

I'll undo the revert in a new PR and figure out the perf regression there

bors · 2022-07-18T06:49:39Z

📌 Commit 63d3cea has been approved by oli-obk

It is now in the queue for this repository.

oli-obk · 2022-07-18T07:14:34Z

Looks like the regression is entirely due to is_useful taking more CPU time

bors · 2022-07-19T20:23:53Z

☔ The latest upstream changes (presumably #99309) made this pull request unmergeable. Please resolve the merge conflicts.

Revert "Rollup merge of rust-lang#98582 - oli-obk:unconstrained_opaque_type, r… …=estebank" This reverts commit 6f8fb91, reversing changes made to 7210e46. r? `@ghost` rebase of rust-lang#99368

…estebank Allow patterns to constrain the hidden type of opaque types fixesrust-lang#96572 reverts a revert as original PR was a perf regression that was fixed by reverting it: rust-lang#99368 (comment)) TODO: * check if rust-lang#99685 is avoided

Allow patterns to constrain the hidden type of opaque types fixes #96572 reverts a revert as original PR was a perf regression that was fixed by reverting it: rust-lang/rust#99368 (comment)) TODO: * check if rust-lang/rust#99685 is avoided

Revert "Rollup merge of #98582 - oli-obk:unconstrained_opaque_type, r… …=estebank" This reverts commit 6f8fb911ad504b77549cf3256a09465621beab9d, reversing changes made to 7210e46dc69a4b197a313d093fe145722c248b7d. r? `@ghost` rebase of rust-lang/rust#99368

Allow patterns to constrain the hidden type of opaque types fixes #96572 reverts a revert as original PR was a perf regression that was fixed by reverting it: rust-lang/rust#99368 (comment)) TODO: * check if rust-lang/rust#99685 is avoided

Revert "Rollup merge of #98582 - oli-obk:unconstrained_opaque_type, r… …=estebank" This reverts commit 6f8fb911ad504b77549cf3256a09465621beab9d, reversing changes made to 7210e46dc69a4b197a313d093fe145722c248b7d. r? `@ghost` rebase of rust-lang/rust#99368

Allow patterns to constrain the hidden type of opaque types fixes #96572 reverts a revert as original PR was a perf regression that was fixed by reverting it: rust-lang/rust#99368 (comment)) TODO: * check if rust-lang/rust#99685 is avoided

Revert "Rollup merge ofrust-lang#98582- oli-obk:unconstrained_opaqu…
63d3cea
…e_type, r=estebank" This reverts commit 6f8fb91, reversing changes made to 7210e46.

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 17, 2022

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 17, 2022

RalfJung mentioned this pull request Jul 17, 2022
Support for "silent" PRs? rust-lang/triagebot#1637
Open

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 17, 2022

matthiaskrgr mentioned this pull request Jul 17, 2022
Rollup of 10 pull requests #99346
Merged

matthiaskrgr closed this Jul 17, 2022

oli-obk reopened this Jul 18, 2022

oli-obk changed the title ~~[perf experiment] Revert "Rollup merge of #98582 - oli-obk:unconstrained_opaque_type, r…~~Revert Allow destructuring opaque types in their defining scopesJul 18, 2022

rust-highfive assigned oli-obk Jul 18, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2022

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 19, 2022

oli-obk closed this Jul 20, 2022

oli-obk mentioned this pull request Jul 20, 2022
Revert "Rollup merge of #98582 - oli-obk:unconstrained_opaque_type, r… #99495
Merged

oli-obk mentioned this pull request Jul 27, 2022
Allow patterns to constrain the hidden type of opaque types #99806
Merged

matthiaskrgr deleted the rev_opaq branch January 25, 2025 09:12

Uh oh!

Uh oh!

Conversation

matthiaskrgr commented Jul 17, 2022• edited by oli-obk Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 17, 2022

Uh oh!

matthiaskrgr commented Jul 17, 2022

Uh oh!

rust-timer commented Jul 17, 2022

Uh oh!

matthiaskrgr commented Jul 17, 2022

Uh oh!

bors commented Jul 17, 2022

Uh oh!

bors commented Jul 17, 2022

Uh oh!

rust-timer commented Jul 17, 2022

Uh oh!

rust-timer commented Jul 17, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

oli-obk commented Jul 18, 2022

Uh oh!

oli-obk commented Jul 18, 2022

Uh oh!

bors commented Jul 18, 2022

Uh oh!

oli-obk commented Jul 18, 2022

Uh oh!

bors commented Jul 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

matthiaskrgr commented Jul 17, 2022•
edited by oli-obk
Loading