Skip to content

Avoid Symbol to &str conversions - #99401

Merged
bors merged 1 commit into
rust-lang:masterfrom
TaKO8Ki:avoid-symbol-to-&str-conversions
Jul 19, 2022
Merged

Avoid Symbol to &str conversions#99401
bors merged 1 commit into
rust-lang:masterfrom
TaKO8Ki:avoid-symbol-to-&str-conversions

Conversation

@TaKO8Ki

@TaKO8KiTaKO8Ki commented Jul 18, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Symbol::as_str is a slowish operation, so this patch removes some usages of it.

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 18, 2022
@rust-highfive

rust-highfive commented Jul 18, 2022

Copy link
Copy Markdown
Contributor

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 18, 2022
@wesleywiser

wesleywiser commented Jul 19, 2022

Copy link
Copy Markdown
Member

@bors try @rust-timer queue

@rust-timer

rust-timer commented Jul 19, 2022

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbotrustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 19, 2022
@bors

bors commented Jul 19, 2022

Copy link
Copy Markdown
Collaborator

⌛ Trying commit a22934b with merge e1806892db33932f6cc438dcac0f51a05bb99abe...

@bors

bors commented Jul 19, 2022

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: e1806892db33932f6cc438dcac0f51a05bb99abe (e1806892db33932f6cc438dcac0f51a05bb99abe)

@rust-timer

rust-timer commented Jul 19, 2022

Copy link
Copy Markdown
Collaborator

Queued e1806892db33932f6cc438dcac0f51a05bb99abe with parent 475aec1, future comparison URL.

@rust-timer

rust-timer commented Jul 19, 2022

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (e1806892db33932f6cc438dcac0f51a05bb99abe): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: 🎉 relevant improvement found
mean1maxcount2
Regressions 😿
(primary)		N/AN/A0
Regressions 😿
(secondary)		N/AN/A0
Improvements 🎉
(primary)		-0.4%-0.4%1
Improvements 🎉
(secondary)		-5.1%-5.1%1
All 😿🎉 (primary)-0.4%-0.4%1

Cycles

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: 🎉 relevant improvement found
mean1maxcount2
Regressions 😿
(primary)		3.7%3.7%1
Regressions 😿
(secondary)		N/AN/A0
Improvements 🎉
(primary)		-2.0%-2.0%1
Improvements 🎉
(secondary)		-3.5%-3.5%1
All 😿🎉 (primary)0.9%3.7%2

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. the arithmetic mean of the percent change↩↩2

  2. number of relevant changes↩↩2

@rustbotrustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 19, 2022
@nnethercote

nnethercote commented Jul 19, 2022

Copy link
Copy Markdown
Contributor

The changed paths must not be hot enough to have a performance effect. But Symbol::as_str is a bit of a dodgy function, so anything that reduces its use is a good thing.

@bors r+

@bors

bors commented Jul 19, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit a22934b has been approved by nnethercote

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2022
@nnethercote

nnethercote commented Jul 19, 2022

Copy link
Copy Markdown
Contributor

@bors rollup=always

@matthiaskrgrmatthiaskrgr mentioned this pull request Jul 19, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 19, 2022
@bors
Auto merge ofrust-lang#99462- matthiaskrgr:rollup-ihhwaru, r=matthi…
a289cfc
…askrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#98028 (Add E0790 as more specific variant of E0283)
- rust-lang#99384 (use body's param-env when checking if type needs drop)
- rust-lang#99401 (Avoid `Symbol` to `&str` conversions)
- rust-lang#99419 (Stabilize `core::task::ready!`)
- rust-lang#99435 (Revert "Stabilize $$ in Rust 1.63.0")
- rust-lang#99438 (Improve suggestions for `NonZeroT` <- `T` coercion error)
- rust-lang#99441 (Update mdbook)
- rust-lang#99453 (:arrow_up: rust-analyzer)
- rust-lang#99457 (use `par_for_each_in` in `par_body_owners` and `collect_crate_mono_items`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 4815f94 into rust-lang:masterJul 19, 2022
@rustbotrustbot added this to the 1.64.0 milestone Jul 19, 2022
@TaKO8Ki
TaKO8Ki deleted the avoid-symbol-to-&str-conversions branch July 19, 2022 21:38
@EnselicEnselic mentioned this pull request Aug 12, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@wesleywiserwesleywiser

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.64.0

Development

Successfully merging this pull request may close these issues.

7 participants

@TaKO8Ki@rust-highfive@wesleywiser@rust-timer@bors@nnethercote@rustbot