Skip to content

Avoid Symbol to String conversions - #99508

Merged
bors merged 2 commits into
rust-lang:masterfrom
TaKO8Ki:avoid-symbol-to-string-conversion-in-BuiltinLintDiagnostics
Jul 20, 2022
Merged

Avoid Symbol to String conversions#99508
bors merged 2 commits into
rust-lang:masterfrom
TaKO8Ki:avoid-symbol-to-string-conversion-in-BuiltinLintDiagnostics

Conversation

@TaKO8Ki

Copy link
Copy Markdown
Member

follow-up to #99342

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 20, 2022
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @compiler-errors

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 20, 2022
@compiler-errors

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jul 20, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 56e7777 has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2022
@compiler-errors

Copy link
Copy Markdown
Contributor

@bors rollup

forgot that lol

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 20, 2022
…askrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#99212 (introduce `implied_by` in `#[unstable]` attribute)
- rust-lang#99352 (Use `typeck_results` to avoid duplicate `ast_ty_to_ty` call)
- rust-lang#99355 (better error for bad depth parameter on macro metavar expr)
- rust-lang#99480 (Diagnostic width span is not added when '0$' is used as width in format strings)
- rust-lang#99488 (compiletest: Allow using revisions with debuginfo tests.)
- rust-lang#99489 (rustdoc UI fixes)
- rust-lang#99508 (Avoid `Symbol` to `String` conversions)
- rust-lang#99510 (adapt assembly/static-relocation-model test for LLVM change)
- rust-lang#99516 (Use new tracking issue for proc_macro::tracked_*.)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 4b21ad2 into rust-lang:masterJul 20, 2022
@rustbotrustbot added this to the 1.64.0 milestone Jul 20, 2022
@TaKO8Ki
TaKO8Ki deleted the avoid-symbol-to-string-conversion-in-BuiltinLintDiagnostics branch July 21, 2022 01:52
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jul 28, 2022
…ersions, r=fee1-dead
Avoid `Symbol` to `String` conversions
follow-up to rust-lang#99508
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jul 28, 2022
…ersions, r=fee1-dead
Avoid `Symbol` to `String` conversions
follow-up to rust-lang#99508
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@TaKO8Ki@rust-highfive@compiler-errors@bors@rustbot