Uh oh!
There was an error while loading. Please reload this page.
Add a clickable link to the layout section - #99700
Merged
Merged
Conversation
rust-highfive
commented
Jul 24, 2022
Contributor
(rust-highfive has picked a reviewer for you, use r? to override) |
est31
marked this pull request as ready for review
July 24, 2022 22:38
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
GuillaumeGomez
commented
Jul 25, 2022
Member
Please add a test in |
est31force-pushed
the
rustdoc_layout_heading
branch
from
July 25, 2022 17:11
1b33257 to
5fcd2f7CompareUh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
GuillaumeGomez
approved these changes
Jul 26, 2022
GuillaumeGomez
commented
Jul 26, 2022
Member
Thanks! r=me once CI pass. |
est31
commented
Jul 26, 2022
MemberAuthor
They do! Please r+ :) |
GuillaumeGomez
commented
Jul 26, 2022
Member
I thought you had r+ rights. My bad. @bors r+ rollup |
bors
commented
Jul 26, 2022
Collaborator
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 26, 2022
…llaumeGomez Add a clickable link to the layout section The layout section (activated by `--show-type-layout`) is currently not linkable to (outside of chrome's link to text feature). This PR makes it linkable via `#layout`.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 27, 2022
Rollup of 8 pull requests Successful merges: - rust-lang#98583 (Stabilize Windows `FileTypeExt` with `is_symlink_dir` and `is_symlink_file`) - rust-lang#99698 (Prefer visibility map parents that are not `doc(hidden)` first) - rust-lang#99700 (Add a clickable link to the layout section) - rust-lang#99712 (passes: port more of `check_attr` module) - rust-lang#99759 (Remove dead code from cg_llvm) - rust-lang#99765 (Don't build std for *-uefi targets) - rust-lang#99771 (Update pulldown-cmark version to 0.9.2 (fixes url encoding for some chars)) - rust-lang#99775 (rustdoc: do not allocate String when writing path full name) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The layout section (activated by
--show-type-layout) is currently not linkable to (outside of chrome's link to text feature). This PR makes it linkable via#layout.