Skip to content

Clean up HIR-based lifetime resolution - #99728

Merged
bors merged 10 commits into
rust-lang:masterfrom
cjgillot:ast-lifetimes-anon-clean
Jul 27, 2022
Merged

Clean up HIR-based lifetime resolution#99728
bors merged 10 commits into
rust-lang:masterfrom
cjgillot:ast-lifetimes-anon-clean

Conversation

@cjgillot

Copy link
Copy Markdown
Contributor

Based on #97313.

Fixes#98932.

r? @petrochenkov

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 25, 2022
@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 25, 2022
@petrochenkov

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jul 26, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit abfb366fc4568e798cc51c5f63666aa2df32537b has been approved by petrochenkov

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2022
@cjgillot
cjgillotforce-pushed the ast-lifetimes-anon-clean branch from abfb366 to 4b2f06bCompareJuly 26, 2022 17:02
@cjgillot

Copy link
Copy Markdown
ContributorAuthor

@bors r=petrochenkov

@bors

bors commented Jul 26, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 4b2f06b has been approved by petrochenkov

It is now in the queue for this repository.

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 27, 2022
…laumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#94247 (Fix slice::ChunksMut aliasing)
- rust-lang#99358 (Allow `ValTree::try_to_raw_bytes` on `u8` array)
- rust-lang#99651 (Deeply deny fn and raw ptrs in const generics)
- rust-lang#99710 (lint: add bad opt access internal lint)
- rust-lang#99717 (Add some comments to the docs issue template to clarify)
- rust-lang#99728 (Clean up HIR-based lifetime resolution)
- rust-lang#99812 (Fix headings colors)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit c37ee1a into rust-lang:masterJul 27, 2022
@rustbotrustbot added this to the 1.64.0 milestone Jul 27, 2022
@cjgillot
cjgillot deleted the ast-lifetimes-anon-clean branch July 27, 2022 21:30
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jul 28, 2022
…r=petrochenkov
Clean up HIR-based lifetime resolution
Based on rust-lang#97313.
Fixesrust-lang#98932.
r? `@petrochenkov`
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Aug 29, 2022
…r-errors
Remove separate indexing of early-bound regions
~Based on rust-lang#99728
This PR copies some modifications from rust-lang#97839 around object lifetime defaults.
These modifications allow to stop counting generic parameters during lifetime resolution, and rely on the indexing given by `rustc_typeck::collect`.
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Aug 29, 2022
…r-errors
Remove separate indexing of early-bound regions
~Based on rust-lang#99728
This PR copies some modifications from rust-lang#97839 around object lifetime defaults.
These modifications allow to stop counting generic parameters during lifetime resolution, and rely on the indexing given by `rustc_typeck::collect`.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression from 1.61 to 1.62

5 participants

@cjgillot@rustbot@petrochenkov@bors@rust-highfive