update few deps by klensy · Pull Request #99768 · rust-lang/rust

klensy · 2022-07-26T16:30:33Z

Updates few crates:

openssl-src v111.18.0+1.1.1n -> v111.22.0+1.1.1q: fixes few CVE's (https://www.openssl.org/news/vulnerabilities-1.1.1.html: https://cve.org/CVERecord?id=CVE-2022-1292 https://cve.org/CVERecord?id=CVE-2022-2068 https://cve.org/CVERecord?id=CVE-2022-2097)
openssl-probe v0.1.2 -> v0.1.5 updates ancient (2017) crate (rustls/openssl-probe@0.1.2...0.1.5). Adds support to search cert for additional platforms.
indoc v1.0.3 -> v1.0.6 (dtolnay/indoc@1.0.3...1.0.6) Nothing special changed, removes unindent v0.1.7
bstr v0.2.13 -> v0.2.17 (BurntSushi/bstr@0.2.13...0.2.17) Few speedups (BurntSushi/bstr@8e65992, BurntSushi/bstr@5fcef91) and bugfix (BurntSushi/bstr@b2111b6)
crc32fast v1.2.0 -> v1.3.2 (srijs/rust-crc32fast@v1.2.0...v1.3.2) Speedup debug (srijs/rust-crc32fast@e61ce6a)
diff v0.1.12 -> v0.1.13 (utkarshkukreti/diff.rs@0.1.12...0.1.13) Few optimizations ([WIP] optimize utkarshkukreti/diff.rs#16, utkarshkukreti/diff.rs@0f0aa58)
ignore v0.4.17 -> v0.4.18 (it's hard to get usable diff, but most notable perf change is BurntSushi/ripgrep@a28e664)
globset v0.4.5 -> v0.4.9
regex v1.5.5 -> v1.5.6 few bugfixes (https://github.com/rust-lang/regex/blob/1.5.6/CHANGELOG.md#156-2022-05-20). There exist 1.6.0 version, but it's too fresh.

rust-highfive · 2022-07-26T16:30:37Z

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

joshtriplett · 2022-07-27T05:44:35Z

@bors r+

bors · 2022-07-27T05:44:37Z

📌 Commit 6c0d3c11a05d3235ced47d325c29cfb6be7620ee has been approved by joshtriplett

It is now in the queue for this repository.

Mark-Simulacrum · 2022-07-27T09:14:27Z

@bors rollup=never

bors · 2022-07-28T00:48:51Z

⌛ Testing commit 6c0d3c11a05d3235ced47d325c29cfb6be7620ee with merge 198615c6cf45a2fd1abdf2e1c31c6c3da122f0d1...

bors · 2022-07-28T01:11:03Z

💔 Test failed - checks-actions

openssl-src v111.18.0+1.1.1n -> v111.22.0+1.1.1q openssl-probe v0.1.2 -> v0.1.5 indoc v1.0.3 -> v1.0.6 bstr v0.2.13 -> v0.2.17 crc32fast v1.2.0 -> v1.3.2 diff v0.1.12 -> v0.1.13 ignore v0.4.17 -> v0.4.18 globset v0.4.5 -> v0.4.9 regex v1.5.5 -> v1.5.6

Mark-Simulacrum · 2022-07-28T13:04:10Z

You'll probably need to adjust the src/tools/rustc-workspace-hack/Cargo.toml to enable that feature for memchr across our workspace.

klensy · 2022-07-28T14:32:00Z

Looks like #99771 recently bumped memchr (BurntSushi/memchr@2.4.1...2.5.0) for stdlib too, so maybe that interfere with this PR crates' version/feature set.

klensy · 2022-07-28T17:56:28Z

@rustbot ready

Rebased and updated rustc-workspace-hack/Cargo.toml.

Mark-Simulacrum · 2022-07-29T13:19:34Z

@bors r+

bors · 2022-07-29T13:19:36Z

📌 Commit 2787d42 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

mqudsi · 2022-07-29T19:46:03Z

+# looks like the only user of deprecated `use_std` feature is `combine`, so this
+# can be removed if/when https://github.com/Marwes/combine/pull/348 be merged and released.
+memchr = { version = "2.5", features = ["std", "use_std"] }
 # same for regex


Nitpick: This comment is now left with an invalid reference! It previously referred to "the previous comment" which spoke about the default features of libz-sys, but you added a comment in between the two and now it looks like "same for regex" means "use_std is deprecated ..."

Looks like it.

So, could someone please file a follow-up PR to fix that comment?

Sure. I assigned #100070 to you.

bors · 2022-07-30T06:54:40Z

⌛ Testing commit 2787d42 with merge 760d8a2...

bors · 2022-07-30T09:35:16Z

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 760d8a2 to master...

rust-timer · 2022-07-30T10:50:54Z

Finished benchmarking commit (760d8a2): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

Primary benchmarks: 😿 relevant regression found
Secondary benchmarks: 😿 relevant regressions found

	mean¹	max	count²
Regressions 😿 (primary)	2.6%	2.6%	1
Regressions 😿 (secondary)	3.6%	4.2%	4
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	2.6%	2.6%	1

Cycles

Results

Primary benchmarks: mixed results
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions 😿 (primary)	2.8%	2.8%	1
Regressions 😿 (secondary)	4.7%	5.6%	5
Improvements 🎉 (primary)	-6.0%	-6.0%	1
Improvements 🎉 (secondary)	-1.6%	-1.6%	1
All 😿🎉 (primary)	-1.6%	-6.0%	2

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

the arithmetic mean of the percent change↩↩²
number of relevant changes↩↩²

Existing comments were left in an incoherent state after rust-lang#99768.

Clarify Cargo.toml comments Existing comments were left in an incoherent state after rust-lang#99768. r? `@RalfJung`

rust-highfive assigned Mark-Simulacrum Jul 26, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 26, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 27, 2022

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 28, 2022

This comment has been minimized.
Sign in to view

update few deps
43512e6
openssl-src v111.18.0+1.1.1n -> v111.22.0+1.1.1q openssl-probe v0.1.2 -> v0.1.5 indoc v1.0.3 -> v1.0.6 bstr v0.2.13 -> v0.2.17 crc32fast v1.2.0 -> v1.3.2 diff v0.1.12 -> v0.1.13 ignore v0.4.17 -> v0.4.18 globset v0.4.5 -> v0.4.9 regex v1.5.5 -> v1.5.6

Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2022

fix memchr features in workspace-hack
2787d42

klensy force-pushed the bump-deps-07-22 branch from 6c0d3c1 to 2787d42Compare July 28, 2022 14:26

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 28, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 29, 2022

mqudsi reviewed Jul 29, 2022
View reviewed changes

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 30, 2022

bors merged commit 760d8a2 into rust-lang:masterJul 30, 2022

rustbot added this to the 1.64.0 milestone Jul 30, 2022

RalfJung mentioned this pull request Aug 2, 2022
./x.py test src/test/ui fails to build compiletest #100062
Closed

mqudsi added a commit to mqudsi/rust that referenced this pull request Aug 2, 2022
Clarify Cargo.toml comments
c61603a
Existing comments were left in an incoherent state after rust-lang#99768.

mqudsi mentioned this pull request Aug 2, 2022
Clarify Cargo.toml comments #100067
Closed

mqudsi added a commit to mqudsi/rust that referenced this pull request Aug 2, 2022
Clarify Cargo.toml comments
63e04ee
Existing comments were left in an incoherent state after rust-lang#99768.

mqudsi mentioned this pull request Aug 2, 2022
Clarify Cargo.toml comments #100070
Merged

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 2, 2022
Rollup merge ofrust-lang#100070- mqudsi:99768_revisited, r=RalfJung
7a6f461
Clarify Cargo.toml comments Existing comments were left in an incoherent state after rust-lang#99768. r? `@RalfJung`

Uh oh!

Uh oh!

Conversation

klensy commented Jul 26, 2022

Uh oh!

rust-highfive commented Jul 26, 2022

Uh oh!

joshtriplett commented Jul 27, 2022

Uh oh!

bors commented Jul 27, 2022

Uh oh!

Mark-Simulacrum commented Jul 27, 2022

Uh oh!

bors commented Jul 28, 2022

Uh oh!

bors commented Jul 28, 2022

Uh oh!

This comment has been minimized.

Mark-Simulacrum commented Jul 28, 2022

Uh oh!

klensy commented Jul 28, 2022

Uh oh!

klensy commented Jul 28, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mark-Simulacrum commented Jul 29, 2022

Uh oh!

bors commented Jul 29, 2022

Uh oh!

mqudsiJul 29, 2022

Choose a reason for hiding this comment

Uh oh!

klensyJul 30, 2022

Choose a reason for hiding this comment

Uh oh!

RalfJungAug 2, 2022

Choose a reason for hiding this comment

Uh oh!

mqudsiAug 2, 2022

Choose a reason for hiding this comment

Uh oh!

bors commented Jul 30, 2022

Uh oh!

bors commented Jul 30, 2022

Uh oh!

rust-timer commented Jul 30, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

klensy commented Jul 28, 2022•
edited
Loading