Skip to content

Delay a bug when failed to normalize trait ref during specialization - #99795

Merged
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:delay-specialization-normalize-error
Aug 4, 2022
Merged

Delay a bug when failed to normalize trait ref during specialization#99795
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:delay-specialization-normalize-error

Conversation

@compiler-errors

Copy link
Copy Markdown
Contributor

The error messages still kinda suck here but they don't ICE anymore...

Fixes#45814
Fixes#43037

r? types

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 27, 2022
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 27, 2022
Comment threadcompiler/rustc_trait_selection/src/traits/specialize/mod.rs Outdated
@spastorino

Copy link
Copy Markdown
Member

@compiler-errors let me know when you address @b-naber comments and I can merge this.

@compiler-errors
compiler-errorsforce-pushed the delay-specialization-normalize-error branch from dd685fe to 16a3601CompareAugust 3, 2022 01:55
@compiler-errors

Copy link
Copy Markdown
ContributorAuthor

Removed the comment.

@spastorino

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Aug 3, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 16a3601 has been approved by spastorino

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 4, 2022
…iaskrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#98771 (Add support for link-flavor rust-lld for iOS, tvOS and watchOS)
- rust-lang#98835 (relate `closure_substs.parent_substs()` to parent fn in NLL)
- rust-lang#99746 (Use `TraitEngine` in more places that don't specifically need `FulfillmentContext::new_in_snapshot`)
- rust-lang#99786 (Recover from C++ style `enum struct`)
- rust-lang#99795 (Delay a bug when failed to normalize trait ref during specialization)
- rust-lang#100029 (Prevent ICE for `doc_alias` on match arm, statement, expression)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 02fcec2 into rust-lang:masterAug 4, 2022
@rustbotrustbot added this to the 1.64.0 milestone Aug 4, 2022
@compiler-errors
compiler-errors deleted the delay-specialization-normalize-error branch August 11, 2023 19:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

specialization involving associated types of unfullfilled traits can cause a panic ICE in trait normalization when specialization enabled

6 participants

@compiler-errors@spastorino@bors@b-naber@rust-highfive@rustbot