Uh oh!
There was an error while loading. Please reload this page.
Rollup of 5 pull requests - #99802
Merged
Merged
Conversation
This reverts commit 5a4601f.
This reverts commit e8d9f38.
It isn't clear most people other than me and it blocks formatting by rustfmt.
This reduces the amount of llvm ir lines for intrinsic related code from 23801 to 20478.
Check that RPITs constrained by a recursive call in a closure are compatible Fixesrust-lang#99073 Adapts a similar visitor pattern to `find_opaque_ty_constraints` (that we use to check TAITs), but with some changes: 0. Only walk the "OnlyBody" children, instead of all items in the RPIT's defining scope 1. Only walk through the body's children if we found a constraining usage 2. Don't actually do any inference, just do a comparison and error if they're mismatched ---- r? `@oli-obk` -- you know all this impl-trait stuff best... is this the right approach? I can explain the underlying issue better if you'd like, in case that might reveal a better solution. Not sure if it's possible to gather up the closure's defining usages of the RPIT while borrowck'ing the outer function, that might be a better place to put this check...
…nst_trait, r=oli-obk Add `Self: ~const Trait` to traits with `#[const_trait]` r? `@oli-obk`
…jorn3 Sync rustc_codegen_cranelift I did a large refactoring of the intrinsics module to remove the intrinsic_match macro which is not very clear to other people. This also enables rustfmt to run on this code. While I already did a sync yesterday, I am going to do another sync again to avoid potential conflicts as those will likely be painful to resolve. r? ``@ghost`` ``@rustbot`` label +A-codegen +A-cranelift +T-compiler
…oval, r=GuillaumeGomez rustdoc: remove Clean trait impls for more items Follow up to rust-lang#99638 and rust-lang#99672
…iler-errors Refactor: use `pluralize!` Use `pluralize!` in more places
JohnTitor
commented
Jul 27, 2022
MemberAuthor
@bors r+ p=5 rollup=never |
bors
commented
Jul 27, 2022
Collaborator
bors
commented
Jul 27, 2022
Collaborator
bors
commented
Jul 27, 2022
Collaborator
☀️ Test successful - checks-actions |
This was referenced Jul 27, 2022
rust-timer
commented
Jul 27, 2022
Collaborator
Finished benchmarking commit (2a22093): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Self: ~const Traitto traits with#[const_trait]#99704 (AddSelf: ~const Traitto traits with#[const_trait])pluralize!#99789 (Refactor: usepluralize!)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup