Skip to content

Fix settings slider on small width screens - #99810

Merged
bors merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:fix-settings-slider-small-width
Jul 28, 2022
Merged

Fix settings slider on small width screens#99810
bors merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:fix-settings-slider-small-width

Conversation

@GuillaumeGomez

Copy link
Copy Markdown
Member

Fixes#99794.

Screenshot of the fix:

Screenshot from 2022-07-27 14-17-08

cc @jsha
r? @notriddle

@GuillaumeGomezGuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Jul 27, 2022
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 27, 2022
@GuillaumeGomezGuillaumeGomez changed the title Fix settings slider small widthFix settings slider on small width screensJul 27, 2022
@notriddle

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Jul 27, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 1564305 has been approved by notriddle

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 27, 2022
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 27, 2022
…small-width, r=notriddle
Fix settings slider on small width screens
Fixesrust-lang#99794.
Screenshot of the fix:
![Screenshot from 2022-07-27 14-17-08](https://user-images.githubusercontent.com/3050060/181250007-55f982d1-89db-45b7-a4f1-0d1729e6a3e3.png)
cc `@jsha`
r? `@notriddle`
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 27, 2022
…small-width, r=notriddle
Fix settings slider on small width screens
Fixesrust-lang#99794.
Screenshot of the fix:
![Screenshot from 2022-07-27 14-17-08](https://user-images.githubusercontent.com/3050060/181250007-55f982d1-89db-45b7-a4f1-0d1729e6a3e3.png)
cc ``@jsha``
r? ``@notriddle``
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 28, 2022
…small-width, r=notriddle
Fix settings slider on small width screens
Fixesrust-lang#99794.
Screenshot of the fix:
![Screenshot from 2022-07-27 14-17-08](https://user-images.githubusercontent.com/3050060/181250007-55f982d1-89db-45b7-a4f1-0d1729e6a3e3.png)
cc ```@jsha```
r? ```@notriddle```
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jul 28, 2022
…small-width, r=notriddle
Fix settings slider on small width screens
Fixesrust-lang#99794.
Screenshot of the fix:
![Screenshot from 2022-07-27 14-17-08](https://user-images.githubusercontent.com/3050060/181250007-55f982d1-89db-45b7-a4f1-0d1729e6a3e3.png)
cc ````@jsha````
r? ````@notriddle````
@Dylan-DPCDylan-DPC mentioned this pull request Jul 28, 2022
@Dylan-DPCDylan-DPC mentioned this pull request Jul 28, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 28, 2022
Rollup of 5 pull requests
Successful merges:
- rust-lang#99714 (Fix regression introduced with rust-lang#99383)
- rust-lang#99723 (Allow using stable os::fd::raw items through unstable os::wasi module)
- rust-lang#99810 (Fix settings slider on small width screens)
- rust-lang#99837 (Avoid `Symbol` to `String` conversions)
- rust-lang#99846 (Refactor `UnresolvedImportError`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 3c4a66d into rust-lang:masterJul 28, 2022
@rustbotrustbot added this to the 1.64.0 milestone Jul 28, 2022
@GuillaumeGomez
GuillaumeGomez deleted the fix-settings-slider-small-width branch July 28, 2022 22:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rustdoc-uiArea: Rustdoc UI (generated HTML)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rustdoc: settings menu toggles are cut off on mobile

5 participants

@GuillaumeGomez@notriddle@bors@rust-highfive@rustbot