Skip to content

Delay formatting trimmed path until lint/error is emitted - #99893

Merged
bors merged 2 commits into
rust-lang:masterfrom
compiler-errors:issue-99387
Aug 6, 2022
Merged

Delay formatting trimmed path until lint/error is emitted#99893
bors merged 2 commits into
rust-lang:masterfrom
compiler-errors:issue-99387

Conversation

@compiler-errors

@compiler-errorscompiler-errors commented Jul 29, 2022

Copy link
Copy Markdown
Contributor

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 29, 2022
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 29, 2022
davidtwco
davidtwco approved these changes Jul 29, 2022
View reviewed changes

@davidtwcodavidtwco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one or two comments then feel free to r=me

Comment threadcompiler/rustc_privacy/src/errors.rs Outdated
Comment threadcompiler/rustc_privacy/src/errors.rs Outdated
@davidtwcodavidtwco added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 2, 2022
@matthiaskrgrmatthiaskrgr mentioned this pull request Aug 3, 2022
Closed
@compiler-errors

compiler-errors commented Aug 5, 2022

Copy link
Copy Markdown
ContributorAuthor

@bors r=davidtwco

@bors

bors commented Aug 5, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 694a010 has been approved by davidtwco

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 5, 2022
@ChunMinChangChunMinChang mentioned this pull request Aug 5, 2022
Merged
@bors

bors commented Aug 6, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 694a010 with merge 76b0484...

@bors

bors commented Aug 6, 2022

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing 76b0484 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Aug 6, 2022
@bors
bors merged commit 76b0484 into rust-lang:masterAug 6, 2022
@rustbotrustbot added this to the 1.65.0 milestone Aug 6, 2022
@rust-timer

rust-timer commented Aug 6, 2022

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (76b0484): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: 😿 relevant regression found
mean1maxcount2
Regressions 😿
(primary)		2.7%2.7%1
Regressions 😿
(secondary)		2.8%2.8%1
Improvements 🎉
(primary)		-4.4%-4.4%1
Improvements 🎉
(secondary)		N/AN/A0
All 😿🎉 (primary)-0.8%-4.4%2

Cycles

This benchmark run did not return any relevant results for this metric.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change↩

  2. number of relevant changes↩

@compiler-errorscompiler-errors mentioned this pull request Aug 14, 2022
Closed
@ehussehuss mentioned this pull request Aug 30, 2022
Closed
ehuss pushed a commit to ehuss/rust that referenced this pull request Aug 31, 2022
@bors@ehuss
Auto merge ofrust-lang#99893- compiler-errors:issue-99387, r=davidtwco
b4b39cd
Delay formatting trimmed path until lint/error is emitted
Fixesrust-lang#99387
r? `@davidtwco`
@ehussehuss mentioned this pull request Aug 31, 2022
Merged
@ehussehuss added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Aug 31, 2022
@ehussehuss modified the milestones: 1.65.0, 1.64.0Aug 31, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 31, 2022
@bors
Auto merge ofrust-lang#101221- ehuss:update-beta-cargo, r=ehuss
4497ac9
[BETA] Beta 1.64 backports
* Cargo:
* remove missed reference to workspace inheritance in unstable.md (rust-lang/cargo#11002)
* Delay formatting trimmed path until lint/error is emitted rust-lang#99893
* Use `node_type_opt` to skip over generics that were not expected rust-lang#100155
* Revert "Remove a back-compat hack on lazy TAIT rust-lang#97346" rust-lang#99860
@compiler-errors
compiler-errors deleted the issue-99387 branch August 11, 2023 20:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidtwcodavidtwcodavidtwco approved these changes

Assignees

@davidtwcodavidtwco

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.64.0

Development

Successfully merging this pull request may close these issues.

ICE: delayed_good_path_bugs: trimmed_def_paths constructed

7 participants

@compiler-errors@bors@rust-timer@davidtwco@ehuss@rust-highfive@rustbot