Uh oh!
There was an error while loading. Please reload this page.
support for GNU configure syntax - #9990
Conversation
brson
commented
Oct 21, 2013
Thanks again @Heather 🎆 |
brson
commented
Oct 21, 2013
@Heather no, I'm not sure about changing |
brson
commented
Oct 21, 2013
Er, that last comment should have been on #9760 |
Cynede
commented
Oct 21, 2013
@brson well I can do it but I guess |
brson
commented
Oct 21, 2013
@Heather Maybe Here are my best guesses for all the default values: Presumably |
Cynede
commented
Oct 22, 2013
@bors it's wrong in my opinion, everything should use prefix to allow sandboxed build and installation. |
thestinger
commented
Oct 22, 2013
|
Cynede
commented
Oct 22, 2013
@thestinger ah, right. I'm wrong there. Will use @brson solution then. |
Cynede
commented
Oct 22, 2013
@brson added correction |
Cynede
commented
Oct 23, 2013
@brson failed to build? where can I see exact log? |
brson
commented
Oct 24, 2013
@Heather the links in bors' output link to the log files. It appears that those links disappeared when you rebased and repushed. I r+ed again so let's see what happens this time. |
Cynede
commented
Oct 24, 2013
@brson |
brson
commented
Oct 24, 2013
@Heather I still don't understand that error on the bots, but I did some tests locally and discovered I needed the following diff in order for all the triple variables to be set up correctly. This does the conversion from the old |
Cynede
commented
Oct 25, 2013
@brson thanks, added this patch. |
Cynede
commented
Oct 25, 2013
|
Re-created: #9760 Now, without adding `pc-linux-gnu` platform Re-created: #9565 t will be useful for unix systems, some package managers and external tools that is passing / maybe looking for GNU configure syntax options. One of related bugs: #5138 Also that could be useful in future if project will really install man pages / other stuff using those variables.
Cynede
commented
Oct 26, 2013
@brson -m32: command not found ? |
Cynede
commented
Oct 28, 2013
Hello... May someone help me to understand what is happening here? Should I rebase my branch now? |
brson
commented
Oct 28, 2013
@Heather I'll try a build on windows and see if I can figure out what's wrong. |
brson
commented
Oct 28, 2013
I can't reproduce this failure. I do see the strange errors about |
Cynede
commented
Oct 29, 2013
@brson rebased |
brson
commented
Oct 30, 2013
I don't want to keep asking for rebases so I rebased and reopened as #10164 |
Add configuration options to `--explain` This PR rearranges some modules, taking `metadata_collector` out of `internal_lints` and making public just the necessary functions for `explain()` to use. The output looks something like this: ```sh $ cargo run --bin cargo-clippy --manifest-path ../rust-clippy/Cargo.toml -- --explain cognitive_complexity ### What it does Checks for methods with high cognitive complexity. ### Why is this bad? Methods of high cognitive complexity tend to be hard to both read and maintain. Also LLVM will tend to optimize small methods better. ### Known problems Sometimes it's hard to find a way to reduce the complexity. ### Example You'll see it when you get the warning. ======================================== Configuration for clippy::cognitive_complexity: - cognitive-complexity-threshold: The maximum cognitive complexity a function can have (default: 25) ``` Fixesrust-lang#9990 r? `@xFrednet` --- changelog: Docs: `cargo clippy --explain LINT` now shows possible configuration options for the explained lint [rust-lang#10751](rust-lang/rust-clippy#10751) <!-- changelog_checked -->
11970: Bump chalk r=lnicola a=lnicola Closesrust-lang#9990, but not rust-lang#6418, rust-lang#10653 bors r+ Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Re-created: #9760
Now, without adding
pc-linux-gnuplatformRe-created: #9565
t will be useful for unix systems, some package managers and external tools that is passing / maybe looking for GNU configure syntax options.
One of related bugs: #5138
Also that could be useful in future if project will really install man pages / other stuff using those variables.