Skip to content

Add diagnostic when using public instead of pub - #99903

Merged
bors merged 1 commit into
masterfrom
unknown repository
Jul 30, 2022
Merged

Add diagnostic when using public instead of pub#99903
bors merged 1 commit into
masterfrom
unknown repository

Conversation

@ghost

@ghostghost commented Jul 29, 2022•
edited by davidtwco
Loading

Copy link
Copy Markdown

Forwarding from #99706

I accidentally broke something(??) in git and the commits in that PR are absolutely not what I did in that branch

Anyways, this is the PR for this now. Adding tests again in a minute.

cc @davidtwco

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 29, 2022
@rust-highfive

rust-highfive commented Jul 29, 2022

Copy link
Copy Markdown
Contributor

r? @michaelwoerister

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 29, 2022
@davidtwco

davidtwco commented Jul 29, 2022

Copy link
Copy Markdown
Member

r? @davidtwco

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@ghost

This comment was marked as outdated.

Sign in to view
@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 29, 2022
@ghost

ghost commented Jul 29, 2022

Copy link
Copy Markdown
Author

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 29, 2022
davidtwco
davidtwco requested changes Jul 29, 2022
View reviewed changes
Comment threadsrc/test/ui/parser/public-instead-of-pub.rs Outdated
Comment threadcompiler/rustc_parse/src/parser/diagnostics.rs Outdated
Comment threadcompiler/rustc_parse/src/parser/diagnostics.rs Outdated
@ghostghost mentioned this pull request Jul 29, 2022
Closed
@davidtwco

davidtwco commented Jul 29, 2022

Copy link
Copy Markdown
Member

Thanks!

@bors r+

@bors

bors commented Jul 29, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit d0e881e has been approved by davidtwco

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 29, 2022
@ghostghost mentioned this pull request Jul 29, 2022
Closed
@Dylan-DPCDylan-DPC mentioned this pull request Jul 30, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 30, 2022
@bors
Auto merge ofrust-lang#99948- Dylan-DPC:rollup-ed5136t, r=Dylan-DPC
038f9e6
Rollup of 5 pull requests
Successful merges:
- rust-lang#99311 (change maybe_body_owned_by to take local def id)
- rust-lang#99862 (Improve type mismatch w/ function signatures)
- rust-lang#99895 (don't call type ascription "cast")
- rust-lang#99900 (remove some manual hash stable impls)
- rust-lang#99903 (Add diagnostic when using public instead of pub)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit df2cf97 into rust-lang:masterJul 30, 2022
@rustbotrustbot added this to the 1.64.0 milestone Jul 30, 2022
@lopopololopopolo mentioned this pull request Aug 1, 2022
Closed
@TheAwitebTheAwiteb mentioned this pull request Aug 5, 2022
Closed
flip1995 pushed a commit to flip1995/rust that referenced this pull request Aug 11, 2022
@bors
Auto merge ofrust-lang#99948- Dylan-DPC:rollup-ed5136t, r=Dylan-DPC
3641b0c
Rollup of 5 pull requests
Successful merges:
- rust-lang#99311 (change maybe_body_owned_by to take local def id)
- rust-lang#99862 (Improve type mismatch w/ function signatures)
- rust-lang#99895 (don't call type ascription "cast")
- rust-lang#99900 (remove some manual hash stable impls)
- rust-lang#99903 (Add diagnostic when using public instead of pub)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
This was referenced Sep 9, 2022
Closed
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@davidtwcodavidtwco

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.64.0

Development

Successfully merging this pull request may close these issues.

6 participants

@rust-highfive@davidtwco@rust-log-analyzer@bors@michaelwoerister@rustbot