Uh oh!
There was an error while loading. Please reload this page.
Update sanitizers documentation - #562
Merged
Merged
Conversation
nikomatsakis
commented
Jan 17, 2020
Contributor
Thanks again for doing this. =) |
mark-i-m
commented
Feb 3, 2020
Contributor
Ping @tmiasko any updates? |
tmiasko
marked this pull request as ready for review
February 3, 2020 13:42
tmiasko
commented
Feb 3, 2020
ContributorAuthor
In part this describes changes from rust-lang/rust#68164 which are yet to land. If that is not an issue we could merge it now and update later as necessary. |
spastorino
commented
Feb 3, 2020
Member
Thanks @tmiasko for the update, I'd wait for rust-lang/rust#68164 to land then. |
tmiasko
commented
Feb 7, 2020
ContributorAuthor
The rust-lang/rust#68164 landed, so this is ready for review & merging. |
mark-i-m
approved these changes
Feb 7, 2020
mark-i-m
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me, but I don't know anything about sanitizers, so I will defer to @nikomatsakis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.