Skip to content

feat: the C AST used by the C codegen backend - #6

Merged
tgross35 merged 12 commits into
rust-lang:mainfrom
Wybxc:ast
Oct 22, 2024
Merged

feat: the C AST used by the C codegen backend#6
tgross35 merged 12 commits into
rust-lang:mainfrom
Wybxc:ast

Conversation

@Wybxc

@WybxcWybxc commented Oct 18, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR adds rustc_codegen_c_ast crate for C AST construction and printing.

@Wybxc
Wybxc marked this pull request as ready for review October 18, 2024 12:53
tgross35
tgross35 requested changes Oct 18, 2024
View reviewed changes

@tgross35tgross35 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, the code is very clean and the docs help a lot. Some minor requests, then feel free to squash and we can merge this (or I can just squash merge).

Comment threadcrates/rustc_codegen_c_ast/src/decl.rs
Comment threadcrates/rustc_codegen_c_ast/src/decl.rs Outdated
Comment threadcrates/rustc_codegen_c_ast/src/pretty.rs Outdated
Comment threadcrates/rustc_codegen_c_ast/src/pretty.rs
Comment threadcrates/rustc_codegen_c_ast/src/stmt.rs Outdated
Comment threadcrates/rustc_codegen_c_ast/src/ty.rs Outdated
Comment threadcrates/rustc_codegen_c_ast/tests/blessed/test_decl_var.out Outdated
@Wybxc
Wybxc requested a review from tgross35October 22, 2024 08:41
@tgross35
tgross35 merged commit aeb8fe5 into rust-lang:mainOct 22, 2024
@tgross35tgross35 mentioned this pull request Oct 22, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgross35tgross35tgross35 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Wybxc@tgross35