Uh oh!
There was an error while loading. Please reload this page.
Add clippy-driver as a proxy - #1679
Merged
Merged
Conversation
kinnison
commented
Mar 4, 2019
ContributorAuthor
@Manishearth Should we be changing |
Manishearth
commented
Mar 4, 2019
Member
No, keep cargo-clippy exactly the same for now. Implementing this will be a long process and we'll need both to be around for a significant amount of time. We'll make a PR removing cargo-clippy when we need to 😄 thanks! |
Manishearth
approved these changes
Mar 4, 2019
dwijnand
commented
Mar 4, 2019
Contributor
Fixes #1678? |
kinnison
commented
Mar 4, 2019
ContributorAuthor
Rats, you're quite right, I forgot that, I'll pop a fix up for that now. |
The Cargo team are taking `cargo clippy` on-board and as such will need `clippy-driver` as a general proxy. Fixes: rust-lang#1678 Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
kinnisonforce-pushed
the
kinnison/cargo-clippy
branch
from
March 4, 2019 08:07
030d853 to
84f3dc8Comparekinnison
commented
Mar 4, 2019
ContributorAuthor
Oops :D I think that'll be good to merge once green. |
Manishearth
commented
Mar 5, 2019
Member
it's green r? @dwijnand |
dwijnand
approved these changes
Mar 5, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Cargo team are taking
cargo clippyon-board and as suchwill need
clippy-driveras a general proxy.Signed-off-by: Daniel Silverstone dsilvers@digital-scurf.org