Uh oh!
There was an error while loading. Please reload this page.
Separate release jobs - #3247
Merged
Merged
Conversation
rbtcollins
commented
Feb 27, 2023
ContributorAuthor
(Note for assessing performance - this resets the cache keys for everything, so a re-run will be needed to really tell. |
rbtcollinsforce-pushed
the
separate-release-jobs
branch
7 times, most recently
from
February 28, 2023 06:58
deb02c2 to
58e3041Comparerbtcollins
marked this pull request as ready for review
February 28, 2023 12:38
rbtcollins
commented
Feb 28, 2023
ContributorAuthor
@hi-rustin this too is ready for review |
0xPoe
reviewed
Mar 2, 2023
0xPoe
left a comment
Member
There was a problem hiding this comment.
Does this mean we don't run any windows tests on PR?
rbtcollinsforce-pushed
the
separate-release-jobs
branch
from
March 2, 2023 06:50
58e3041 to
99973d1Comparerbtcollins
commented
Mar 2, 2023
ContributorAuthor
Hmm, my intent was certainly to run windows tests. Lets me see whats happening. |
rbtcollins
commented
Mar 2, 2023
ContributorAuthor
https://github.com/rust-lang/rustup/actions/runs/4311356314 is the problem |
Debug and release build artifacts shouldn't be mixed in one cache. Build them in different jobs.
rbtcollinsforce-pushed
the
separate-release-jobs
branch
from
March 2, 2023 06:53
99973d1 to
6dc031dComparerbtcollins
commented
Mar 2, 2023
ContributorAuthor
(And fixed). @hi-rustin I'm going to merge this - its a substantial win - if you have any further comments let me know and I'll fix them up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is layered on the hardlink PR; it hopefully makes things even faster by only building whats needed in release mode.