Skip to content

Refine suggestions of sourcing $HOME/.cargo/env - #3445

Merged
rbtcollins merged 1 commit into
rust-lang:masterfrom
rami3l:fix/better-source-suggestions
Aug 20, 2023
Merged

Refine suggestions of sourcing $HOME/.cargo/env#3445
rbtcollins merged 1 commit into
rust-lang:masterfrom
rami3l:fix/better-source-suggestions

Conversation

@rami3l

Copy link
Copy Markdown
Member

Closes#3415.

djc
djc approved these changes Aug 16, 2023

@djcdjc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by review: nice!

@rami3l

rami3l commented Aug 16, 2023

Copy link
Copy Markdown
MemberAuthor

@rbtcollins The CI check failed spuriously and requires a rerun.

@rami3l
rami3lforce-pushed the fix/better-source-suggestions branch from e682122 to d861ebaCompareAugust 16, 2023 12:57
@rami3l

Copy link
Copy Markdown
MemberAuthor

Weird. After a rerun I'm still getting errors that should have nothing to do with my changes...

@djc

djc commented Aug 18, 2023

Copy link
Copy Markdown
Contributor

The armv7-linux issues are an upstream problem: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/rustup.20CI.20fails.20to.20install.20Docker.20images.20for.20armv7-linux. macOS seems to be suffering from intermittent issues in different tests. I think we should just merge this despite the CI failures.

@rbtcollins
rbtcollins merged commit a4dd7d0 into rust-lang:masterAug 20, 2023
@rami3l
rami3l deleted the fix/better-source-suggestions branch August 20, 2023 06:20
@rami3lrami3l added this to the 1.27.0 milestone Jan 18, 2024
@rami3lrami3l mentioned this pull request Jan 29, 2024
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rustup suggest executing "source ...", but this command is absent in dash

3 participants

@rami3l@djc@rbtcollins