Skip to content

feat(cli): warn when removing the last/host target for a toolchain, pt. 2 - #3643

Merged
rami3l merged 3 commits into
masterfrom
refactor/warn-target-uninstall
Jan 19, 2024
Merged

feat(cli): warn when removing the last/host target for a toolchain, pt. 2#3643
rami3l merged 3 commits into
masterfrom
refactor/warn-target-uninstall

Conversation

@rami3l

@rami3lrami3l commented Jan 18, 2024

Copy link
Copy Markdown
Member

Addresses the concerns in #3637 (comment) and #3637 (comment).

Comment threadsrc/cli/rustup_mode.rs
djc
djc approved these changes Jan 18, 2024
@rami3l

Copy link
Copy Markdown
MemberAuthor

@djc Looks like we're hitting https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/rustup.20CI.20fails.20to.20install.20Docker.20images.20for.20armv7-linux again. Did we do anything in particular to workaround/solve this issue when it last happened?

@rami3lrami3l added this to the 1.27.0 milestone Jan 18, 2024
@rami3l
rami3l added this pull request to the merge queue Jan 19, 2024
Merged via the queue into master with commit 0a72c68Jan 19, 2024
@rami3l
rami3l deleted the refactor/warn-target-uninstall branch January 19, 2024 01:58
@rami3lrami3l mentioned this pull request Jan 29, 2024
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rami3l@djc