Uh oh!
There was an error while loading. Please reload this page.
Windows: Try using symlinks if they're allowed - #3687
Conversation
djc
left a comment
There was a problem hiding this comment.
Seems nice! Maybe add a comment to explain why we think symlinks are the better option here?
ChrisDenton
commented
Feb 27, 2024
Something like that? |
djc
commented
Feb 28, 2024
This seems okay, going to merge this. Thanks! |
@ChrisDenton I don't use Windows personally but I have a question: will this create a possibly inconsistent state where one part of the installation is organized with symlinks and another part with juncture points? |
ChrisDenton
commented
Feb 29, 2024
That could happen but I can't think of a case where the type of link would matter to us. Except, as previously mentioned, when moving the rustup directory. In that case you'll end up with some links being broken while others aren't but I'm not sure that's any worse than all links being broken. |
Windows requires Developer Mode to be enabled to use symlinks without admin permissions. This isn't always enabled, so fall back to using junction points if symlink creation fails. This is for example what rustup does already. See rust-lang/rustup#3687 for example.
Windows requires Developer Mode to be enabled to use symlinks without admin permissions. This isn't always enabled, so fall back to using junction points if symlink creation fails. This is for example what rustup does already. See rust-lang/rustup#3687 for example.
Windows requires Developer Mode to be enabled to use symlinks without admin permissions. This isn't always enabled, so fall back to using junction points if symlink creation fails. This is for example what rustup does already. See rust-lang/rustup#3687 for example.
Windows requires Developer Mode to be enabled to use symlinks without admin permissions. This isn't always enabled, so fall back to using junction points if symlink creation fails. This is for example what rustup does already. See rust-lang/rustup#3687 for example.
Windows requires Developer Mode to be enabled to use symlinks without admin permissions. This isn't always enabled, so fall back to using junction points if symlink creation fails. This is for example what rustup does already. See rust-lang/rustup#3687 for example.
Windows requires Developer Mode to be enabled to use symlinks without admin permissions. This isn't always enabled, so fall back to using junction points if symlink creation fails. This is for example what rustup does already. See rust-lang/rustup#3687 for example.
On Windows, creating symlinks is not allowed unless developer mode is enabled or a specific permission is granted. Therefore this optimistically attempts to use symlinks first, before falling back to juncture points in the event that fails.
Resolves#3677