Uh oh!
There was an error while loading. Please reload this page.
fix(ci): don't use pip3 to install awscli - #3786
Merged
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
rami3l
marked this pull request as draft
April 24, 2024 01:38
brew to install awscli on macOS runnerspip3 to install awscli on macOS runnerspip3 to install awscli on macOS runnerspip3 install awsclirami3lforce-pushed
the
fix/dist-awscli-macos
branch
from
April 24, 2024 02:52
331ccbb to
e44ba70Comparerami3l
marked this pull request as ready for review
April 24, 2024 02:54
rami3lforce-pushed
the
fix/dist-awscli-macos
branch
from
April 24, 2024 03:01
dcb559c to
2e52628Comparepip3 install awsclipip3 to install awsclirami3lforce-pushed
the
fix/dist-awscli-macos
branch
from
April 24, 2024 03:12
2e52628 to
6bf342aComparerami3l
enabled auto-merge
April 24, 2024 03:36
djc
approved these changes
Apr 24, 2024
rami3l
added this pull request to the merge queue
Apr 24, 2024
djc
commented
Apr 24, 2024
Contributor
Nice work looking into this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
stableCI is almost perfect except it gives this error onmacos-14:This is actions/runner-images#8615; it so happened that when we were releasing v1.27.0,
pip3was on Python v3.11, so that didn't bring up any error message.Since
awscliis already bundled inmacos-(12|14)andubuntu-*,pip3 install awscliactually has no effect. I think it’d be better to make the installation line a version check instead.For
windowsrunners, the existingawscliis alreadychoco-managed, so there's nothing to be done.It's worth noticing that the preinstalled
awscliis on v2, but onpipwe have awscli 1.32.89 as the latest version. However, given that we've already used the v2 for release purposes unintentionally for quite a while now, the differences here regarding the specificaws s3 cpcommand should be minimal.This fix cannot be properly tested since it touches some part of the release process, but the
aws --versionpart has been tested and is guaranteed to work.